Explicitly check for undefined in React Material Select

awolokita · sdirix · web-flow · commit 5da2f0d3afce · 2021-08-30T17:18:55.000+02:00
In MuiSelect the value was set to the empty string when the incoming data
was falsy. This lead to problems when for example the number zero is
an expected value.

We now only check for `undefined` and hand over all other values.

Co-authored-by: Stefan Dirix &lt;sdirix@eclipsesource.com&gt;
diff --git a/packages/material/src/mui-controls/MuiSelect.tsx b/packages/material/src/mui-controls/MuiSelect.tsx
@@ -50,7 +50,7 @@ export const MuiSelect = React.memo((props: EnumCellProps & WithClassname) => {
       id={id}
       disabled={!enabled}
       autoFocus={appliedUiSchemaOptions.focus}
-      value={data || ''}
+      value={data !== undefined ? data : ''}
       onChange={ev => handleChange(path, ev.target.value)}
       fullWidth={true}
     >

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export const MuiSelect = React.memo((props: EnumCellProps & WithClassname) => {`
`50`	`50`	`id={id}`
`51`	`51`	`disabled={!enabled}`
`52`	`52`	`autoFocus={appliedUiSchemaOptions.focus}`
`53`		`- value={data \|\| ''}`
	`53`	`+ value={data !== undefined ? data : ''}`
`54`	`54`	`onChange={ev => handleChange(path, ev.target.value)}`
`55`	`55`	`fullWidth={true}`
`56`	`56`	`>`