Merge pull request #1250 from amvanbaren/improve-fix-missing-files-migration

Improve FixMissingFilesJobRequestHandler

Author: amvanbaren

server/src/main/java/org/eclipse/openvsx/migration/FixMissingFilesJobRequestHandler.java

@@ -56,6 +56,9 @@ public void run(MigrationJobRequest request) throws Exception {
         var missingFileTypes = new ArrayList<>(List.of(MANIFEST, CHANGELOG, README, LICENSE, ICON, VSIXMANIFEST));
         missingFileTypes.removeAll(resourceTypes);
         resources.filter(this::isFileMissing).map(FileResource::getType).forEach(missingFileTypes::add);
+        if(missingFileTypes.isEmpty()) {
+            return;
+        }
         if(missingFileTypes.stream().anyMatch(t -> t.equals(FileResource.DOWNLOAD))) {
             logger.atInfo()
                     .setMessage("No vsix package available for: {}")
@@ -64,6 +67,12 @@ public void run(MigrationJobRequest request) throws Exception {
             return;
         }
 
+        logger.atInfo()
+                .setMessage("{} has missing files: {}")
+                .addArgument(() -> NamingUtil.toLogFormat(extVersion))
+                .addArgument(() -> String.join(",", missingFileTypes))
+                .log();
+
         var download = resources.stream().filter(f -> f.getType().equals(FileResource.DOWNLOAD)).findFirst().get();
         try(
                 var tempFile = storage.downloadFile(download);