Avoid recompiling pattern in Connection URI parsers

Applies to DB2, MySQL, PostgreSQL and MSSQL.

The cost of compiling regular expression (in particular complex ones) can be avoided.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

Author: tsegismont

vertx-db2-client/src/main/java/io/vertx/db2client/impl/DB2ConnectionUriParser.java

@@ -15,8 +15,7 @@
  */
 package io.vertx.db2client.impl;
 
-import static java.lang.Integer.parseInt;
-import static java.lang.String.format;
+import io.vertx.core.json.JsonObject;
 
 import java.io.UnsupportedEncodingException;
 import java.net.URLDecoder;
@@ -25,7 +24,8 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import io.vertx.core.json.JsonObject;
+import static java.lang.Integer.parseInt;
+import static java.lang.String.format;
 
 /**
  * This is a parser for parsing connection URIs of DB2.
@@ -43,9 +43,9 @@ public class DB2ConnectionUriParser {
   private static final String DATABASE_REGEX = "(/(?<database>[a-zA-Z0-9\\-._~%!*]+))?"; // database name
   private static final String ATTRIBUTES_REGEX = "(\\?(?<attributes>.*))?"; // attributes
 
-  private static final String FULL_URI_REGEX = "^" // regex start
-      + SCHEME_DESIGNATOR_REGEX + USER_INFO_REGEX + NET_LOCATION_REGEX + PORT_REGEX + DATABASE_REGEX + ATTRIBUTES_REGEX
-      + "$"; // regex end
+  private static final Pattern FULL_URI_REGEX = Pattern.compile("^" // regex start
+    + SCHEME_DESIGNATOR_REGEX + USER_INFO_REGEX + NET_LOCATION_REGEX + PORT_REGEX + DATABASE_REGEX + ATTRIBUTES_REGEX
+    + "$"); // regex end
 
   public static JsonObject parse(String connectionUri) {
     // if we get any exception during the parsing, then we throw an IllegalArgumentException.
@@ -60,8 +60,7 @@ public static JsonObject parse(String connectionUri) {
 
   // execute the parsing process and store options in the configuration
   private static void doParse(String connectionUri, JsonObject configuration) {
-    Pattern pattern = Pattern.compile(FULL_URI_REGEX);
-    Matcher matcher = pattern.matcher(connectionUri);
+    Matcher matcher = FULL_URI_REGEX.matcher(connectionUri);
 
     if (matcher.matches()) {
       // parse the user and password

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionUriParser.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2020 Contributors to the Eclipse Foundation
+ * Copyright (c) 2011-2021 Contributors to the Eclipse Foundation
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License 2.0 which is available at
@@ -35,14 +35,14 @@ public class MSSQLConnectionUriParser {
   private static final String DATABASE_REGEX = "(/(?<database>[a-zA-Z0-9\\-._~%!*]+))?"; // database name
   private static final String ATTRIBUTES_REGEX = "(\\?(?<attributes>.*))?"; // attributes
 
-  private static final String FULL_URI_REGEX = "^" // regex start
+  private static final Pattern FULL_URI_REGEX = Pattern.compile("^" // regex start
     + SCHEME_DESIGNATOR_REGEX
     + USER_INFO_REGEX
     + NET_LOCATION_REGEX
     + PORT_REGEX
     + DATABASE_REGEX
     + ATTRIBUTES_REGEX
-    + "$"; // regex end
+    + "$"); // regex end
 
   public static JsonObject parse(String connectionUri) {
     // if we get any exception during the parsing, then we throw an IllegalArgumentException.
@@ -57,8 +57,7 @@ public static JsonObject parse(String connectionUri) {
 
   // execute the parsing process and store options in the configuration
   private static void doParse(String connectionUri, JsonObject configuration) {
-    Pattern pattern = Pattern.compile(FULL_URI_REGEX);
-    Matcher matcher = pattern.matcher(connectionUri);
+    Matcher matcher = FULL_URI_REGEX.matcher(connectionUri);
 
     if (matcher.matches()) {
       // parse the user and password

vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionUriParser.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2020 Contributors to the Eclipse Foundation
+ * Copyright (c) 2011-2021 Contributors to the Eclipse Foundation
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License 2.0 which is available at
@@ -35,14 +35,14 @@ public class MySQLConnectionUriParser {
   private static final String SCHEMA_REGEX = "(/(?<schema>[a-zA-Z0-9\\-._~%!*]+))?"; // schema name
   private static final String ATTRIBUTES_REGEX = "(\\?(?<attributes>.*))?"; // attributes
 
-  private static final String FULL_URI_REGEX = "^" // regex start
+  private static final Pattern FULL_URI_REGEX = Pattern.compile("^" // regex start
     + SCHEME_DESIGNATOR_REGEX
     + USER_INFO_REGEX
     + NET_LOCATION_REGEX
     + PORT_REGEX
     + SCHEMA_REGEX
     + ATTRIBUTES_REGEX
-    + "$"; // regex end
+    + "$"); // regex end
 
   public static JsonObject parse(String connectionUri) {
     // if we get any exception during the parsing, then we throw an IllegalArgumentException.
@@ -57,8 +57,7 @@ public static JsonObject parse(String connectionUri) {
 
   // execute the parsing process and store options in the configuration
   private static void doParse(String connectionUri, JsonObject configuration) {
-    Pattern pattern = Pattern.compile(FULL_URI_REGEX);
-    Matcher matcher = pattern.matcher(connectionUri);
+    Matcher matcher = FULL_URI_REGEX.matcher(connectionUri);
 
     if (matcher.matches()) {
       // parse the user and password

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionUriParser.java

@@ -16,8 +16,8 @@
  */
 package io.vertx.pgclient.impl;
 
-import io.vertx.pgclient.SslMode;
 import io.vertx.core.json.JsonObject;
+import io.vertx.pgclient.SslMode;
 
 import java.io.UnsupportedEncodingException;
 import java.net.URLDecoder;
@@ -43,14 +43,14 @@ public class PgConnectionUriParser {
   private static final String DATABASE_REGEX = "(/(?<database>[a-zA-Z0-9\\-._~%!*]+))?"; // database name
   private static final String PARAMS_REGEX = "(\\?(?<params>.*))?"; // parameters
 
-  private static final String FULL_URI_REGEX = "^" // regex start
+  private static final Pattern FULL_URI_REGEX = Pattern.compile("^" // regex start
     + SCHEME_DESIGNATOR_REGEX
     + USER_INFO_REGEX
     + NET_LOCATION_REGEX
     + PORT_REGEX
     + DATABASE_REGEX
     + PARAMS_REGEX
-    + "$"; // regex end
+    + "$"); // regex end
 
   public static JsonObject parse(String connectionUri) {
     // if we get any exception during the parsing, then we throw an IllegalArgumentException.
@@ -65,8 +65,7 @@ public static JsonObject parse(String connectionUri) {
 
   // execute the parsing process and store options in the configuration
   private static void doParse(String connectionUri, JsonObject configuration) {
-    Pattern pattern = Pattern.compile(FULL_URI_REGEX);
-    Matcher matcher = pattern.matcher(connectionUri);
+    Matcher matcher = FULL_URI_REGEX.matcher(connectionUri);
 
     if (matcher.matches()) {
       // parse the user and password