WIP - unable to get the correct result out

Author: psolomin

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionImpl.java

@@ -137,9 +137,12 @@ public Query<RowSet<Row>> copyToRows(String sql) {
 
   @Override
   public Future<SqlResult<Buffer>> copyToBytes(String sql) {
-    Function<Buffer, SqlResultImpl<Buffer>> factory = SqlResultImpl::new;
+    Function<Buffer, SqlResultImpl<Buffer>> factory = (buffer) -> new SqlResultImpl<>(buffer);
     PromiseInternal<SqlResult<Buffer>> promise = context.promise();
 
+    // currently, this loads entire content into Buffer
+    // it should stream bytes out instead
+    // TODO: signal completion as soon as the database replied CopyOutResponse 'H' ?
     QueryResultBuilder<Buffer, SqlResultImpl<Buffer>, SqlResult<Buffer>> resultHandler =
       new QueryResultBuilder<>(factory, promise);
 

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/codec/CopyOutCommand.java

@@ -7,7 +7,6 @@
 import io.vertx.sqlclient.impl.SqlResultImpl;
 import io.vertx.sqlclient.impl.command.CommandBase;
 
-import java.util.function.Function;
 import java.util.stream.Collector;
 
 public class CopyOutCommand extends CommandBase<SqlResult<Buffer>> {
@@ -25,7 +24,7 @@ public CopyOutCommand(
       Buffer::buffer,
       (v, chunk) -> v.appendBuffer(Buffer.buffer(chunk)),
       (v1, v2) -> null,
-      Function.identity()
+      (finalResult) -> finalResult
     );
   }
 

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/codec/CopyOutCommandCodec.java

@@ -3,6 +3,7 @@
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.buffer.impl.BufferImpl;
 import io.vertx.sqlclient.SqlResult;
+import io.vertx.sqlclient.impl.SqlResultImpl;
 
 class CopyOutCommandCodec extends PgCommandCodec<SqlResult<Buffer>, CopyOutCommand> {
   CopyOutDataDecoder decoder;
@@ -14,7 +15,7 @@ class CopyOutCommandCodec extends PgCommandCodec<SqlResult<Buffer>, CopyOutComma
 
   @Override
   public void handleCommandComplete(int updated) {
-    this.result = null;
+    this.result = new SqlResultImpl<Buffer>(Buffer.buffer("abc"));
     Buffer result;
     Throwable failure;
     int size;

vertx-pg-client/src/test/java/io/vertx/pgclient/PgConnectionCopyTest.java

@@ -2,7 +2,6 @@
 
 import io.vertx.ext.unit.Async;
 import io.vertx.ext.unit.TestContext;
-import org.junit.Ignore;
 import org.junit.Test;
 
 public class PgConnectionCopyTest extends PgConnectionTestBase {
@@ -74,6 +73,7 @@ public void testSimpleQuery(TestContext ctx) {
       conn
         .query("select 1")
         .execute()
+        // when does the result is transformed from bool to rows?
         .onComplete(ctx.asyncAssertSuccess(result1 -> {
           ctx.assertEquals(1, result1.size());
           async.complete();