Skip to content

Commit 8abdd71

Browse files
committed
Removed redundant overridden test methods from OracleConnectionTest
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
1 parent 2aeed29 commit 8abdd71

File tree

1 file changed

+0
-62
lines changed

1 file changed

+0
-62
lines changed

vertx-oracle-client/src/test/java/io/vertx/oracleclient/test/tck/OracleConnectionTest.java

Lines changed: 0 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -38,55 +38,6 @@ public void tearDown(TestContext ctx) {
3838
super.tearDown(ctx);
3939
}
4040

41-
@Test
42-
public void testConnect(TestContext ctx) {
43-
Async async = ctx.async();
44-
connect(ctx.asyncAssertSuccess(conn -> async.complete()));
45-
}
46-
47-
@Test
48-
public void testConnectInvalidDatabase(TestContext ctx) {
49-
Async async = ctx.async();
50-
options.setDatabase("invalidDatabase");
51-
connect(ctx.asyncAssertFailure(err -> {
52-
ctx.assertTrue(err.getMessage().contains("ORA-12514"));
53-
async.complete();
54-
}));
55-
}
56-
57-
@Test
58-
public void testConnectInvalidPassword(TestContext ctx) {
59-
Async async = ctx.async();
60-
options.setPassword("invalidPassword");
61-
connect(ctx.asyncAssertFailure(err -> {
62-
ctx.assertTrue(err.getMessage().contains("ORA-01017"));
63-
async.complete();
64-
}));
65-
}
66-
67-
@Test
68-
public void testConnectInvalidUsername(TestContext ctx) {
69-
Async async = ctx.async();
70-
options.setUser("invalidUsername");
71-
connect(ctx.asyncAssertFailure(err -> {
72-
ctx.assertTrue(err.getMessage().contains("ORA-01017"));
73-
async.complete();
74-
}));
75-
}
76-
77-
@Test
78-
public void testClose(TestContext ctx) {
79-
Async closedAsync = ctx.async();
80-
Async closeAsync = ctx.async();
81-
connect(ctx.asyncAssertSuccess(conn -> {
82-
conn.closeHandler(v -> {
83-
closedAsync.complete();
84-
});
85-
conn.close(ctx.asyncAssertSuccess(v -> closeAsync.complete()));
86-
}));
87-
closedAsync.await();
88-
}
89-
9041
@Test
9142
public void testCloseWithErrorInProgress(TestContext ctx) {
9243
Async async = ctx.async(2);
@@ -115,19 +66,6 @@ public void testCloseWithQueryInProgress(TestContext ctx) {
11566
async.await();
11667
}
11768

118-
@Test
119-
public void testDatabaseMetaData(TestContext ctx) {
120-
connect(ctx.asyncAssertSuccess(conn -> {
121-
DatabaseMetadata md = conn.databaseMetadata();
122-
ctx.assertNotNull(md, "DatabaseMetadata should not be null");
123-
ctx.assertNotNull(md.productName(), "Database product name should not be null");
124-
ctx.assertNotNull(md.fullVersion(), "Database full version string should not be null");
125-
ctx.assertTrue(md.majorVersion() >= 1, "Expected DB major version to be >= 1 but was " + md.majorVersion());
126-
ctx.assertTrue(md.minorVersion() >= 0, "Expected DB minor version to be >= 0 but was " + md.minorVersion());
127-
validateDatabaseMetaData(ctx, md);
128-
}));
129-
}
130-
13169
@Override
13270
protected void validateDatabaseMetaData(TestContext ctx, DatabaseMetadata md) {
13371
ctx.assertTrue(md.fullVersion().contains("Oracle"));

0 commit comments

Comments
 (0)