Skip to content

Commit 81cbcd3

Browse files
committed
Remove un-necessary internal promise creation from handler
1 parent 6c8fe5a commit 81cbcd3

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PoolImpl.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,6 @@ protected ContextInternal context() {
116116
return vertx.getOrCreateContext();
117117
}
118118

119-
@Override
120-
protected <T> PromiseInternal<T> promise(Handler<AsyncResult<T>> handler) {
121-
return vertx.promise(handler);
122-
}
123-
124119
@Override
125120
public Future<SqlConnection> getConnection() {
126121
ContextInternal current = vertx.getOrCreateContext();

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SqlClientBase.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ public SqlClientBase(Driver driver, QueryTracer tracer, ClientMetrics metrics) {
5757

5858
protected abstract <T> PromiseInternal<T> promise();
5959

60-
protected abstract <T> PromiseInternal<T> promise(Handler<AsyncResult<T>> handler);
61-
6260
@Override
6361
public Driver driver() {
6462
return driver;
@@ -198,11 +196,6 @@ protected <T> PromiseInternal<T> promise() {
198196
return SqlClientBase.this.promise();
199197
}
200198

201-
@Override
202-
protected <T> PromiseInternal<T> promise(Handler<AsyncResult<T>> handler) {
203-
return SqlClientBase.this.promise(handler);
204-
}
205-
206199
@Override
207200
public <R> Future<R> schedule(ContextInternal context, CommandBase<R> cmd) {
208201
return composite.add(context, cmd);

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SqlConnectionBase.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,6 @@ protected <T> PromiseInternal<T> promise() {
9797
return context.promise();
9898
}
9999

100-
@Override
101-
protected <T> PromiseInternal<T> promise(Handler<AsyncResult<T>> handler) {
102-
return context.promise(handler);
103-
}
104-
105100
@Override
106101
public void handleClosed() {
107102
Handler<Void> handler = closeHandler;

0 commit comments

Comments
 (0)