Cleanup in ConnectionFactoryBase

Author: vietj

vertx-db2-client/src/main/java/io/vertx/db2client/impl/DB2ConnectionFactory.java

@@ -42,16 +42,6 @@ public DB2ConnectionFactory(VertxInternal vertx, Supplier<DB2ConnectOptions> opt
     super(vertx, options);
   }
 
-  @Override
-  protected void initializeConfiguration(SqlConnectOptions connectOptions) {
-    DB2ConnectOptions options = (DB2ConnectOptions) connectOptions;
-  }
-
-  @Override
-  protected void configureNetClientOptions(NetClientOptions netClientOptions) {
-    // currently no-op
-  }
-
   @Override
   protected Future<Connection> doConnectInternal(DB2ConnectOptions options, EventLoopContext context) {
     SocketAddress server = options.getSocketAddress();

vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionFactory.java

@@ -40,16 +40,6 @@ public MSSQLConnectionFactory(VertxInternal vertx, Supplier<MSSQLConnectOptions>
     super(vertx, options);
   }
 
-  @Override
-  protected void initializeConfiguration(SqlConnectOptions options) {
-    // currently no-op
-  }
-
-  @Override
-  protected void configureNetClientOptions(NetClientOptions netClientOptions) {
-    netClientOptions.setSsl(false);
-  }
-
   @Override
   protected Future<Connection> doConnectInternal(MSSQLConnectOptions options, EventLoopContext context) {
     return connectOrRedirect(options, context, 0);

vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionFactory.java

@@ -42,14 +42,6 @@ public MySQLConnectionFactory(VertxInternal vertx, Supplier<MySQLConnectOptions>
     super(vertx, options);
   }
 
-  @Override
-  protected void initializeConfiguration(SqlConnectOptions connectOptions) {
-  }
-
-  @Override
-  protected void configureNetClientOptions(NetClientOptions netClientOptions) {
-  }
-
   @Override
   protected Future<Connection> doConnectInternal(MySQLConnectOptions options, EventLoopContext context) {
     SslMode sslMode = options.isUsingDomainSocket() ? SslMode.DISABLED : options.getSslMode();

vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java

@@ -52,10 +52,6 @@ public PgConnectionFactory(VertxInternal context, Supplier<PgConnectOptions> opt
     super(context, options);
   }
 
-  @Override
-  protected void initializeConfiguration(SqlConnectOptions connectOptions) {
-  }
-
   private void checkSslMode(PgConnectOptions options) {
     switch (options.getSslMode()) {
       case VERIFY_FULL:
@@ -72,11 +68,6 @@ private void checkSslMode(PgConnectOptions options) {
     }
   }
 
-  @Override
-  protected void configureNetClientOptions(NetClientOptions netClientOptions) {
-    netClientOptions.setSsl(false);
-  }
-
   @Override
   protected Future<Connection> doConnectInternal(PgConnectOptions options, EventLoopContext context) {
     try {

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/ConnectionFactoryBase.java

@@ -112,20 +112,6 @@ private void doConnectWithRetry(C options, PromiseInternal<Connection> promise,
     });
   }
 
-  /**
-   * Initialize the configuration after the common configuration have been initialized.
-   *
-   * @param options the concrete options for initializing configuration by a specific connection factory.
-   */
-  protected abstract void initializeConfiguration(SqlConnectOptions options);
-
-  /**
-   * Apply the configuration to the {@link NetClientOptions NetClientOptions} for connecting to the database.
-   *
-   * @param netClientOptions NetClient options to apply
-   */
-  protected abstract void configureNetClientOptions(NetClientOptions netClientOptions);
-
   /**
    * Establish a connection to the server.
    */