Rename enum to TransactionPropagation

Author: technical-debt-collector

vertx-sql-client/src/main/java/io/vertx/sqlclient/Pool.java

@@ -168,7 +168,7 @@ default <T> void withTransaction(Function<SqlConnection, Future<@Nullable T>> fu
    * Like {@link #withTransaction(Function, Handler)} but allows for setting the mode, defining how the acquired
    * connection is managed during the execution of the function.
    */
-  <T> Future<@Nullable T> withTransaction(TransactionMode mode, Function<SqlConnection, Future<@Nullable T>> function);
+  <T> Future<@Nullable T> withTransaction(TransactionPropagation txPropagation, Function<SqlConnection, Future<@Nullable T>> function);
 
   /**
    * Get a connection from the pool and execute the given {@code function}.

vertx-sql-client/src/main/java/io/vertx/sqlclient/TransactionMode.java renamed to vertx-sql-client/src/main/java/io/vertx/sqlclient/TransactionPropagation.java

@@ -15,22 +15,22 @@
 
 /**
  * Defines how the acquired connection will be managed during the execution of the function provided in
- * {@link Pool#withTransaction(TransactionMode, Function)}.
+ * {@link Pool#withTransaction(TransactionPropagation, Function)}.
  */
-public enum TransactionMode {
+public enum TransactionPropagation {
 
   /**
    * The acquired connection is not stored anywhere, making it local to the provided function execution and to
-   * whereever it is passed.
+   * wherever it is passed.
    */
-  DEFAULT,
+  NONE,
 
   /**
    * Keeps the acquired connection stored in the local context for as long as the given function executes.
    * Any subsequent calls to {@link Pool#withTransaction} with this mode during the function execution
    * will retrieve this connection from the context instead of creating another.
    * The connection is removed from the local context when the function block has completed.
    */
-  PROPAGATABLE
+  CONTEXT
 
 }

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PoolBase.java

@@ -72,9 +72,9 @@ public PreparedQuery<RowSet<Row>> preparedQuery(String sql) {
   }
 
   @Override
-  public <T> Future<@Nullable T> withTransaction(TransactionMode mode,
+  public <T> Future<@Nullable T> withTransaction(TransactionPropagation txPropagation,
                                                  Function<SqlConnection, Future<@Nullable T>> function) {
-    return delegate.withTransaction(mode, function);
+    return delegate.withTransaction(txPropagation, function);
   }
 
   @Override

vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PoolImpl.java

@@ -155,9 +155,9 @@ public Future<SqlConnection> getConnection() {
     });
   }
 
-  public <T> Future<@Nullable T> withTransaction(TransactionMode mode,
+  public <T> Future<@Nullable T> withTransaction(TransactionPropagation txPropagation,
                                                  Function<SqlConnection, Future<@Nullable T>> function) {
-    if (mode == TransactionMode.PROPAGATABLE) {
+    if (txPropagation == TransactionPropagation.CONTEXT) {
       ContextInternal context = (ContextInternal) Vertx.currentContext();
       SqlConnection sqlConnection = context.getLocal(PROPAGATABLE_CONNECTION);
       if (sqlConnection == null) {

vertx-sql-client/src/test/java/io/vertx/sqlclient/tck/TransactionTestBase.java

@@ -314,10 +314,10 @@ public void testWithPropagatableConnectionTransactionCommit(TestContext ctx) {
     Async async = ctx.async();
     Pool pool = createPool();
     vertx.runOnContext(handler -> {
-    pool.withTransaction(TransactionMode.PROPAGATABLE, c ->
-      pool.withTransaction(TransactionMode.PROPAGATABLE, conn ->
+    pool.withTransaction(TransactionPropagation.CONTEXT, c ->
+      pool.withTransaction(TransactionPropagation.CONTEXT, conn ->
         conn.query("INSERT INTO mutable (id, val) VALUES (1, 'hello-1')").execute().mapEmpty()).flatMap(v ->
-        pool.withTransaction(TransactionMode.PROPAGATABLE, conn ->
+        pool.withTransaction(TransactionPropagation.CONTEXT, conn ->
           conn.query("INSERT INTO mutable (id, val) VALUES (2, 'hello-2')").execute().mapEmpty())).flatMap(v2 ->
         c.query("INSERT INTO mutable (id, val) VALUES (3, 'hello-3')").execute().mapEmpty())
     ).onComplete(ctx.asyncAssertSuccess(v -> pool
@@ -336,8 +336,8 @@ public void testWithPropagatableConnectionTransactionRollback(TestContext ctx) {
     Pool pool = createPool();
     Throwable failure = new Throwable();
     vertx.runOnContext(handler -> {
-      pool.withTransaction(TransactionMode.PROPAGATABLE, c ->
-        pool.withTransaction(TransactionMode.PROPAGATABLE, conn ->
+      pool.withTransaction(TransactionPropagation.CONTEXT, c ->
+        pool.withTransaction(TransactionPropagation.CONTEXT, conn ->
           conn.query("INSERT INTO mutable (id, val) VALUES (1, 'hello-1')").execute().mapEmpty().flatMap(
             v -> Future.failedFuture(failure)))
       ).onComplete(ctx.asyncAssertFailure(v -> pool