Skip to content

Commit 1ea3a2d

Browse files
committed
Make test consume modularity
1 parent 122628c commit 1ea3a2d

File tree

20 files changed

+148
-415
lines changed

20 files changed

+148
-415
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
<tls.connection.uri/>
5353
<unix.socket.directory/>
5454
<unix.socket.port/>
55-
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
55+
<vertx.surefire.useModulePath>true</vertx.surefire.useModulePath>
5656
<testcontainers.version>1.17.6</testcontainers.version>
5757
</properties>
5858

@@ -151,7 +151,7 @@
151151
<execution>
152152
<id>default-testCompile</id>
153153
<configuration>
154-
<useModulePath>false</useModulePath>
154+
<useModulePath>${vertx.surefire.useModulePath}</useModulePath>
155155
</configuration>
156156
</execution>
157157
</executions>

vertx-db2-client/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
<properties>
3535
<vertx.asciidoc.sources.dir>${project.basedir}/src/main/asciidoc/*.adoc,${project.basedir}/../vertx-sql-client/src/main/asciidoc/*.adoc</vertx.asciidoc.sources.dir>
36+
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
3637
</properties>
3738

3839
<dependencies>

vertx-db2-client/src/main/java/module-info.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
requires io.vertx.core.logging;
1111
requires java.sql;
1212

13+
provides io.vertx.sqlclient.spi.Driver with io.vertx.db2client.spi.DB2Driver; // Un-tested
14+
1315
exports io.vertx.db2client;
1416
exports io.vertx.db2client.spi;
1517

vertx-mssql-client/src/main/java/module-info.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@
1010
requires io.vertx.core.logging;
1111
requires java.sql;
1212

13+
provides io.vertx.sqlclient.spi.Driver with io.vertx.mssqlclient.spi.MSSQLDriver;
14+
1315
exports io.vertx.mssqlclient;
1416
exports io.vertx.mssqlclient.spi;
1517

18+
exports io.vertx.mssqlclient.impl to io.vertx.tests.sql.client.mssql;
19+
1620
requires static io.vertx.docgen;
1721
requires static io.vertx.codegen.api;
1822
requires static io.vertx.codegen.json;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
open module io.vertx.tests.sql.client.mssql {
2+
3+
requires io.vertx.core;
4+
requires io.vertx.sql.client;
5+
requires io.vertx.sql.client.mssql;
6+
requires io.vertx.tests.sql.client;
7+
requires java.sql;
8+
requires io.vertx.testing.unit;
9+
requires junit;
10+
requires testcontainers;
11+
12+
}

vertx-mysql-client/src/main/java/module-info.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,16 @@
1010
requires io.vertx.core.logging;
1111
requires java.sql;
1212

13+
provides io.vertx.sqlclient.spi.Driver with io.vertx.mysqlclient.spi.MySQLDriver;
14+
1315
exports io.vertx.mysqlclient;
1416
exports io.vertx.mysqlclient.spi;
1517
exports io.vertx.mysqlclient.data.spatial;
1618

19+
exports io.vertx.mysqlclient.impl to io.vertx.tests.sql.client.mysql;
20+
exports io.vertx.mysqlclient.impl.util to io.vertx.tests.sql.client.mysql;
21+
exports io.vertx.mysqlclient.impl.protocol to io.vertx.tests.sql.client.mysql;
22+
1723
requires static io.vertx.docgen;
1824
requires static io.vertx.codegen.api;
1925
requires static io.vertx.codegen.json;

vertx-mysql-client/src/test/java/io/vertx/tests/mysqlclient/MySQLUnixDomainSocketTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,12 @@ public void setUp() {
5656

5757
@After
5858
public void after() {
59-
client.close().await();
60-
vertx.close().await();
59+
if (client != null) {
60+
client.close().await();
61+
}
62+
if (vertx != null) {
63+
vertx.close().await();
64+
}
6165
}
6266

6367
@Test
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
open module io.vertx.tests.sql.client.mysql {
2+
3+
requires io.netty.common;
4+
requires io.netty.buffer;
5+
requires io.vertx.core;
6+
requires io.vertx.sql.client;
7+
requires io.vertx.sql.client.mysql;
8+
requires io.vertx.tests.sql.client;
9+
requires java.sql;
10+
requires io.vertx.testing.unit;
11+
requires junit;
12+
requires testcontainers;
13+
14+
}

vertx-oracle-client/src/main/java/module-info.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,14 @@
1111
requires io.vertx.core.logging;
1212
requires java.sql;
1313

14+
provides io.vertx.sqlclient.spi.Driver with io.vertx.oracleclient.spi.OracleDriver;
15+
1416
exports io.vertx.oracleclient;
1517
exports io.vertx.oracleclient.data;
1618
exports io.vertx.oracleclient.spi;
1719

20+
exports io.vertx.oracleclient.impl to io.vertx.tests.sql.client.oracle;
21+
1822
requires static io.vertx.docgen;
1923
requires static io.vertx.codegen.api;
2024
requires static io.vertx.codegen.json;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
open module io.vertx.tests.sql.client.oracle {
2+
3+
requires io.vertx.core;
4+
requires io.vertx.sql.client;
5+
requires io.vertx.sql.client.oracle;
6+
requires io.vertx.tests.sql.client;
7+
requires java.sql;
8+
requires io.vertx.testing.unit;
9+
requires junit;
10+
requires testcontainers;
11+
12+
}

0 commit comments

Comments
 (0)