Build release target in github workflows (#326)

ryanwinter · web-flow · commit 03aa4af83447 · 2022-02-11T22:42:59.000-08:00
* add release to build workflow
support lto in release mode for arm

* update link script locatioon

* pre-initialize variable

* disable uninitialized warning for rx_driver_package

* disable inline of assembly to remove duplicate symbols

* add additional newlib nano aliases for getpid and kill for renesas cloud kit

* simplify workflow

* split debug and release workflow build by matrix
diff --git a/.github/workflows/ATSAME54-XPRO.yml b/.github/workflows/ATSAME54-XPRO.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" 
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
           cmake --build build
diff --git a/.github/workflows/AZ3166.yml b/.github/workflows/AZ3166.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/EFR32MG12.yml b/.github/workflows/EFR32MG12.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/L475E-IOT01A.yml b/.github/workflows/L475E-IOT01A.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/L4S5I-IOT01A.yml b/.github/workflows/L4S5I-IOT01A.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m4.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/MIMXRT1050-EVKB.yml b/.github/workflows/MIMXRT1050-EVKB.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m7.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m7.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/MIMXRT1060-EVK.yml b/.github/workflows/MIMXRT1060-EVK.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
+        type: [Debug, Release]
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m7.cmake" 
-          cmake --build build
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/arm-gcc-cortex-m7.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
+          cmake --build build   
diff --git a/.github/workflows/RSK-RX65N-2MB.yml b/.github/workflows/RSK-RX65N-2MB.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
+        type: [Debug, Release]        
 
     steps:
       - name: Checkout code
@@ -31,7 +32,7 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/renesas-rx-gcc-rx65n.cmake" 
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/renesas-rx-gcc-rx65n.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
           cmake --build build
diff --git a/.github/workflows/RX65N-Cloud-Kit.yml b/.github/workflows/RX65N-Cloud-Kit.yml
@@ -16,6 +16,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
+        type: [Debug, Release]        
 
     steps:
       - name: Checkout code
@@ -31,7 +32,8 @@ jobs:
       - name: Install Ninja
         uses: seanmiddleditch/gha-setup-ninja@v3
 
-      - name: Build project
+      - name: Build binary
         run: |
-          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/renesas-rx-gcc-rx65n.cmake" 
+          cmake -Bbuild -GNinja -DCMAKE_TOOLCHAIN_FILE="../../cmake/renesas-rx-gcc-rx65n.cmake" -DCMAKE_BUILD_TYPE="${{ matrix.type }}"
           cmake --build build
+
diff --git a/MXChip/AZ3166/app/CMakeLists.txt b/MXChip/AZ3166/app/CMakeLists.txt
@@ -1,8 +1,6 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
-set(LINKER_SCRIPT "${CMAKE_CURRENT_SOURCE_DIR}/startup/MXChip_AZ3166.ld")
-
 set(SOURCES
     startup/system_stm32f4xx.c
     startup/startup_stm32f412rx.s
@@ -36,10 +34,16 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME} 
+    PUBLIC 
+       startup
+)
+
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
     message(FATAL_ERROR, "IAR is not currently implemented for this device")
 else()
-    set_target_linker(${PROJECT_NAME} ${LINKER_SCRIPT})
+    set_target_linker(${PROJECT_NAME} MXChip_AZ3166.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/Microchip/ATSAME54-XPRO/app/CMakeLists.txt b/Microchip/ATSAME54-XPRO/app/CMakeLists.txt
@@ -30,10 +30,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME}
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/same54x20_flash.icf)
+    set_target_linker(${PROJECT_NAME} same54x20_flash.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/same54p20a_flash.ld)
+    set_target_linker(${PROJECT_NAME} same54p20a_flash.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/Microchip/ATSAME54-XPRO/lib/atmel_start/src/hpl/core/hpl_core_m4.c b/Microchip/ATSAME54-XPRO/lib/atmel_start/src/hpl/core/hpl_core_m4.c
@@ -211,6 +211,7 @@ void _delay_init(void *const hw)
 /**
  * \brief Delay loop to delay n number of cycles
  */
+__attribute__((noinline))
 void _delay_cycles(void *const hw, uint32_t cycles)
 {
 #ifndef _UNIT_TEST_
diff --git a/NXP/MIMXRT1050-EVKB/app/CMakeLists.txt b/NXP/MIMXRT1050-EVKB/app/CMakeLists.txt
@@ -30,10 +30,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME}
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/MIMXRT1052xxxxx_flexspi_nor.icf)
+    set_target_linker(${PROJECT_NAME} MIMXRT1052xxxxx_flexspi_nor.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/MIMXRT1052xxxxx_flexspi_nor.ld)
+    set_target_linker(${PROJECT_NAME} MIMXRT1052xxxxx_flexspi_nor.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/NXP/MIMXRT1060-EVK/app/CMakeLists.txt b/NXP/MIMXRT1060-EVK/app/CMakeLists.txt
@@ -30,10 +30,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME}
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/MIMXRT1062xxxxx_flexspi_nor.icf)
+    set_target_linker(${PROJECT_NAME} MIMXRT1062xxxxx_flexspi_nor.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/MIMXRT1062xxxxx_flexspi_nor.ld)
+    set_target_linker(${PROJECT_NAME} MIMXRT1062xxxxx_flexspi_nor.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/Renesas/RSK_RX65N_2MB/app/CMakeLists.txt b/Renesas/RSK_RX65N_2MB/app/CMakeLists.txt
@@ -32,10 +32,16 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME} 
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}    
+)
+
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
     message(FATAL_ERROR, "IAR is not currently implemented for this device")
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/linker_script.ld)
+    set_target_linker(${PROJECT_NAME} linker_script.ld)
     target_link_options(${PROJECT_NAME} PRIVATE -Wl,-e_PowerON_Reset)
 endif()
 
diff --git a/Renesas/RSK_RX65N_2MB/app/startup/gnu/linker_script.ld b/Renesas/RSK_RX65N_2MB/app/startup/gnu/linker_script.ld
@@ -6,7 +6,7 @@ MEMORY
 	OFS : ORIGIN = 0xFE7F5D00, LENGTH = 128
 }
 
-INCLUDE ../app/startup/gnu/linker_script_rvectors_extern.inc
+INCLUDE linker_script_rvectors_extern.inc
 
 SECTIONS
 {
@@ -30,7 +30,7 @@ SECTIONS
 	.rvectors ALIGN(4):
 	{
 		_rvectors_start = .;
-		INCLUDE ../app/startup/gnu/linker_script_rvectors.inc
+		INCLUDE linker_script_rvectors.inc
 		_rvectors_end = .;
 	} > ROM
 	.init :
diff --git a/Renesas/RSK_RX65N_2MB/lib/rx_driver_package/CMakeLists.txt b/Renesas/RSK_RX65N_2MB/lib/rx_driver_package/CMakeLists.txt
@@ -50,6 +50,11 @@ add_library(${TARGET} OBJECT
     ${SOURCES}
 )
 
+target_compile_options(${TARGET}
+    PRIVATE
+        -Wno-maybe-uninitialized
+)
+
 target_include_directories(${TARGET}
     PUBLIC
         src/smc_gen/general
diff --git a/Renesas/RX65N_Cloud_Kit/app/CMakeLists.txt b/Renesas/RX65N_Cloud_Kit/app/CMakeLists.txt
@@ -32,10 +32,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME} 
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}    
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/linker_script.icf)
+    set_target_linker(${PROJECT_NAME} linker_script.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/linker_script.ld)
+    set_target_linker(${PROJECT_NAME} linker_script.ld)
     target_link_options(${PROJECT_NAME} PRIVATE -Wl,-e_PowerON_Reset)
 endif()
 
diff --git a/Renesas/RX65N_Cloud_Kit/app/startup/gnu/linker_script.ld b/Renesas/RX65N_Cloud_Kit/app/startup/gnu/linker_script.ld
@@ -6,7 +6,7 @@ MEMORY
 	OFS : ORIGIN = 0xFE7F5D00, LENGTH = 128
 }
 
-INCLUDE ../app/startup/gnu/linker_script_rvectors_extern.inc
+INCLUDE linker_script_rvectors_extern.inc
 
 SECTIONS
 {
@@ -30,7 +30,7 @@ SECTIONS
 	.rvectors ALIGN(4):
 	{
 		_rvectors_start = .;
-		INCLUDE ../app/startup/gnu/linker_script_rvectors.inc
+		INCLUDE linker_script_rvectors.inc
 		_rvectors_end = .;
 	} > ROM
 	.init :
diff --git a/STMicroelectronics/B-L475E-IOT01A/app/CMakeLists.txt b/STMicroelectronics/B-L475E-IOT01A/app/CMakeLists.txt
@@ -32,10 +32,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME}
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/stm32l475xx_flash.icf)
+    set_target_linker(${PROJECT_NAME} stm32l475xx_flash.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/STM32L475xx_FLASH.ld)
+    set_target_linker(${PROJECT_NAME} STM32L475xx_FLASH.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/STMicroelectronics/B-L4S5I-IOT01A/app/CMakeLists.txt b/STMicroelectronics/B-L4S5I-IOT01A/app/CMakeLists.txt
@@ -32,10 +32,15 @@ target_include_directories(${PROJECT_NAME}
         .
 )
 
+target_link_directories(${PROJECT_NAME}
+    PUBLIC 
+       startup/${THREADX_TOOLCHAIN}
+)
+
 if(CMAKE_C_COMPILER_ID STREQUAL "IAR")
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/iar/stm32l4s5xx_flash.icf)
+    set_target_linker(${PROJECT_NAME} stm32l4s5xx_flash.icf)
 else()
-    set_target_linker(${PROJECT_NAME} ${CMAKE_CURRENT_LIST_DIR}/startup/gnu/STM32L4S5VITx_FLASH.ld)
+    set_target_linker(${PROJECT_NAME} STM32L4S5VITx_FLASH.ld)
 endif()
 
 post_build(${PROJECT_NAME})
diff --git a/STMicroelectronics/B-L4S5I-IOT01A/app/board_init.c b/STMicroelectronics/B-L4S5I-IOT01A/app/board_init.c
@@ -95,7 +95,7 @@ void board_init(void)
 
 int hardware_rand(void)
 {
-    uint32_t rand;
+    uint32_t rand = 0;
     HAL_RNG_GenerateRandomNumber(&hrng, &rand);
     return rand;
 }
diff --git a/SiliconLabs/EFR32MG12/app/CMakeLists.txt b/SiliconLabs/EFR32MG12/app/CMakeLists.txt
diff --git a/cmake/arm-gcc-cortex-toolchain.cmake b/cmake/arm-gcc-cortex-toolchain.cmake
diff --git a/cmake/arm-iar-cortex-toolchain.cmake b/cmake/arm-iar-cortex-toolchain.cmake
diff --git a/cmake/renesas-rx-gcc-toolchain.cmake b/cmake/renesas-rx-gcc-toolchain.cmake
diff --git a/shared/src/azure_iot_mqtt/sha256.c b/shared/src/azure_iot_mqtt/sha256.c
diff --git a/shared/src/newlib_nano.c b/shared/src/newlib_nano.c
