Missing file name in rename dialog error

[umeWaheed]

Bug Description:

theia/packages/workspace/src/browser/workspace-commands.ts

Line 391 in 58532a6

return nls.localizeByDefault('The name **{0}** is not valid as a file or folder name. Please choose a different name.');

Steps to Reproduce:

1. right click any file/folder in explorer view
2. click rename
3. enter a name with trailing /
4. the error shows like this

Additional Information

Need to add argument this.trimFileName(name) in the translation string

• Operating System: windows 11 (edge)

[ndoschek]

Hi @umeWaheed, thank you for reporting this!
The localized string is missing the file name argument unfortunately (see its usage here).
If you're up for contributing that fix, that would be very welcome 🙌

[umeWaheed]

yes I can