-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
Bug Description:
Debug sessions cannot be started using "Debug: Start Debugging" from the toolbar. This is an issue I first noticed when moving from Theia 1.58.4 to Theia 1.64.1.
Steps to Reproduce:
- In the command palette, select "Toolbar: Add Command to Toolbar".
- Select the command "Debug: Start Debugging".
- Assign some icon to the command and chose a column for it to be placed in.
- With some launch configuration defined, click on that icon in the toolbar.
- Nothing notable will happen, contrary to expectation.
Additional Information
My understanding of the root cause is as follows:
In Theia 1.58.4, after having assigned the command "Debug: Start Debugging" to a toolbar button, the onCLick
handler for that button would eventually result in a call to DebugFrontendApplicationContribution.start
with no debugSessionOptions
argument. This would result in DebugSessionManager.start
being called with options
set to this.configurations.current
at the end of the start
method.
Now, due to the fact that we pass in a widget here, the debugSesionOptions
argument ends up being a ToolbarImpl
, and this gets passed to DebugSessionManager.start
. Because a ToolbarImpl
has no configuration
property, DebugSessionManager.startCompound
is wrongly called. Finally, since a ToolbarImpl
has no property compound
, an error is thrown here.
- Operating System: Windows 11
- Theia Version: 1.64.1