Compile errors after upgrade to 1.60

[vnfedotov]

After upgrading to Theia 1.60 there's bunch of compile errors pointing to Theia source files. I just checked - they haven't changed in years. So, what did?

node_modules/@theia/core/src/browser/preferences/preference-contribution.ts:189:25 - error TS2351: This expression is not constructable.
  Type '{ default: { (options?: Options | undefined): Ajv; new (options?: Options | undefined): Ajv; ValidationError: typeof ValidationError; MissingRefError: typeof MissingRefError; $dataMetaSchema: object; }; ValidationError: typeof ValidationError; MissingRefError: typeof MissingRefError; $dataMetaSchema: object; }' has no construct signatures.

189         const ajv = new Ajv();
                            ~~~

  node_modules/@theia/core/src/browser/preferences/preference-contribution.ts:17:1
    17 import * as Ajv from 'ajv';
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.

node_modules/@theia/core/src/browser/label-provider.ts:18:28 - error TS7016: Could not find a declaration file for module 'file-icons-js'. '/Users/vnfedotov/git/gaia/core/node_modules/file-icons-js/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/file-icons-js` if it exists or add a new declaration (.d.ts) file containing `declare module 'file-icons-js';`

18 import * as fileIcons from 'file-icons-js';
                              ~~~~~~~~~~~~~~~

node_modules/@theia/core/src/browser/markdown-rendering/markdown-renderer.ts:68:37 - error TS2349: This expression is not callable.
  Type '{ default: MarkdownItConstructor; }' has no call signatures.

68     protected readonly markdownIt = markdownit();
                                       ~~~~~~~~~~

  node_modules/@theia/core/src/browser/markdown-rendering/markdown-renderer.ts:19:1
    19 import * as markdownit from 'markdown-it';
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.

node_modules/@theia/core/src/browser/markdown-rendering/markdown-renderer.ts:88:48 - error TS7006: Parameter 'tokens' implicitly has an 'any' type.

88         this.markdownIt.renderer.rules.text = (tokens, idx) => {
                                                  ~~~~~~

node_modules/@theia/core/src/browser/markdown-rendering/markdown-renderer.ts:88:56 - error TS7006: Parameter 'idx' implicitly has an 'any' type.

88         this.markdownIt.renderer.rules.text = (tokens, idx) => {
                                                          ~~~

[msujew]

Hey @vnfedotov,

can you try to set the "skipLibCheck": true option in your tsconfig.json of your Theia project? Perhaps a TypeScript version update changed how it interacts with dependencies and now you have to specifically disable the lib checking done by TypeScript.

[vnfedotov]

It's already set to true. We're using pretty much the same tsconfig as Theia does.

[vnfedotov]

Caused by import from theia/core/src sneaking into our extension code.