Plexus.lookup(...)s ComponentLookupException wraps unexpected NoSuchElementException

[kwin]

When trying to load a component via Plexus.lookup(...) whose class cannot be found for some reason one gets the following exception

org.codehaus.plexus.component.repository.exception.ComponentLookupException: java.util.NoSuchElementException
      role: org.eclipse.sisu.plexus.test.invalid.InvalidClass
  roleHint: 
	at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:271)
	at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:247)
	at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:241)
	at ....
Caused by: java.util.NoSuchElementException
	at java.util.Collections$EmptyIterator.next(Collections.java:4191)
	at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:267)
	... 22 more

The wrapped exception should contain some more concrete information why the lookup failed (i.e. the exception exposed from the class loader)

OTOH Plexus.lookupList() and Plexus.lookupMap() do not throw an exception at all, but just return empty wrappers.

[kwin]

The reason is the unconditional call to Iterator.next().getValue() in https://github.com/eclipse-sisu/sisu-project/blob/25c3c4aa397984f51491c0819e156e5e2961db40/org.eclipse.sisu.plexus/src/main/java/org/codehaus/plexus/DefaultPlexusContainer.java#L265C47-L265C55 which fails in case the iterator contains no elements. Unfortunately the underlying

sisu-project/org.eclipse.sisu.plexus/src/main/java/org/codehaus/plexus/DefaultPlexusContainer.java

Lines 743 to 751 in 25c3c4a

	catch ( final Exception e )
	{
	// drop through...
	}
	catch ( final LinkageError e )
	{
	// drop through...
	}
	}

just disregards any class loading exceptions.

[kwin]

@cstamas Any thoughts on this one?

[cstamas]

I'd not bother too much with Plexus, is dead, and we are moving off from it.