Skip to content

Disable cache usage #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Disable cache usage #115

merged 2 commits into from
Jul 12, 2024

Conversation

pstuecker
Copy link
Contributor

If no temp path is given, CEF behaves as if a private window is opened. As local storage is not used, we do not need the temp path.

This comment has been minimized.

@pstuecker
Copy link
Contributor Author

/license-check

This comment has been minimized.

Copy link

@mariusheine mariusheine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite this one question it looks fine. Although I don't understand most of the implications of the code changes

@pstuecker pstuecker merged commit 18e61a8 into main Jul 12, 2024
4 checks passed
@pstuecker pstuecker deleted the no-cache branch July 12, 2024 09:16
pstuecker added a commit that referenced this pull request Jul 16, 2024
pstuecker added a commit that referenced this pull request Jul 17, 2024
* Revert "Disable cache usage (#115)"

This reverts commit 18e61a8.

* Use a per-process cache path

* Reapply linter fixes

* Also clean cache directory if the current process exits
pstuecker added a commit to SuB-PlanPro/browser that referenced this pull request Jul 23, 2024
* Revert "Disable cache usage (eclipse-set#115)"

This reverts commit 18e61a8.

* Use a per-process cache path

* Reapply linter fixes

* Also clean cache directory if the current process exits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants