Custom Structure updates only when DataChangeTrigger is Status/Value/Timestamp

[johannwesely]

Hello,

I have a custom structure in milo 1.0.1 server where i only see the changes of the values inside the structure when i set the Monitored item Setting for Data Change Trigger to Status/Value/Timestamp (In UA Expert)

But i want to get changes also for the Data Change Trigger Setting Status/Value what am i missing ?

Greetings Johann

[kevinherron]

Proper hashCode and equals implementation so that Objects.equals works?

milo/opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/util/DataChangeMonitoringFilter.java

Lines 103 to 105 in 696bf00

	private static boolean valueChanged(DataValue lastValue, DataValue currentValue) {
	return !Objects.equals(lastValue.value(), currentValue.value());
	}

[johannwesely]

looks accurate to me i also generated hash code and equals new.

	@Override
	public boolean equals(Object o) {
		if (this == o) {
			return true;
		}
		if (o == null || getClass() != o.getClass()) {
			return false;
		}
		DT_ProcessingTimesDataType that = (DT_ProcessingTimesDataType) o;
		return Objects.equals(startTime, that.startTime) && Objects.equals(endTime, that.endTime) && Objects.equals(acquisitionDuration, that.acquisitionDuration) && Objects.equals(processingDuration, that.processingDuration);
	}

	@Override
	public int hashCode() {
		return Objects.hash(startTime, endTime, acquisitionDuration, processingDuration);
	}

any other ideas ?

[kevinherron]

Not sure, set a breakpoint there and see if you're even reaching it.

Otherwise it depends on you have implemented the monitoring (using SubscriptionModel , roll your own, etc...) and maybe how you are changing the value.

[kevinherron]

When you modify DT_ProcessingTimesDataType are you creating a new instance or did you make mutable structures and are you mutating a field?

[johannwesely]

I just reach Hash but not equals method ?
I do something like this

	if (objectValue instanceof ToxUaStructure) {
						v = new Variant(objectValue);

ToxUaStructure extends UaStructuredType
and then set the Value.
variableNode.setValue(new DataValue(v));

The DT_ProcessingTimes Looks like this:

public class DT_ProcessingTimesDataType extends AbsStructureSubClass implements ToxUaStructure<DT_ProcessingTimesDataType>, IOpcUaRemnantData {


	public static final ExpandedNodeId TYPE_ID = ExpandedNodeId.parse(String.format("nsu=%s;s=%s", NamespaceIds.BWM.getName(), "Types/DataTypes/BaseDataType/Structure/DT_ProcessingTimesDataType"));
	public static final ExpandedNodeId BINARY_ENCODING_ID = ExpandedNodeId.parse(String.format("nsu=%s;i=%s", NamespaceIds.BWM.getName(), "5038"));
	public static final ExpandedNodeId XML_ENCODING_ID = ExpandedNodeId.parse(String.format("nsu=%s;i=%s", NamespaceIds.BWM.getName(), "5039"));
	//
	public static final String F1 = "StartTime";
	public static final String F2 = "EndTime";
	public static final String F3 = "AcquisitionDuration";
	public static final String F4 = "ProcessingDuration";
	private Instant startTime = Instant.now();
	private Instant endTime = Instant.now();
	private Duration acquisitionDuration = Duration.ZERO;
	private Duration processingDuration = Duration.ZERO;

	public DT_ProcessingTimesDataType(Instant startTime, Instant endTime, Duration aquisitionDuration, Duration processingDuration) {
		this.startTime = startTime;
		this.endTime = endTime;
		this.acquisitionDuration = aquisitionDuration;
		this.processingDuration = processingDuration;
	}

	public DT_ProcessingTimesDataType() {
		this(Instant.now(), Instant.now(), Duration.ZERO, Duration.ZERO);
	}

	public static DT_ProcessingTimesDataType parseXml(Node node) {
		DT_ProcessingTimesDataType processingTimes = new DT_ProcessingTimesDataType();

		String startTime = node.getAttributes().getNamedItem(F1).getNodeValue();
		String endTime = node.getAttributes().getNamedItem(F2).getNodeValue();
		String acquisitionDuration = node.getAttributes().getNamedItem(F3).getNodeValue();
		String processingDuration = node.getAttributes().getNamedItem(F4).getNodeValue();

		processingTimes.setStartTime(Instant.parse(startTime));
		processingTimes.setEndTime(Instant.parse(endTime));
		processingTimes.setAcquisitionDuration(Duration.parse(acquisitionDuration));
		processingTimes.setProcessingDuration(Duration.parse(processingDuration));
		return processingTimes;
	}

	public static DT_ProcessingTimesDataType parseXmlElements(Node node, DT_ProcessingTimesDataType oldValue) {
		DT_ProcessingTimesDataType processingTimes = oldValue == null ? new DT_ProcessingTimesDataType() : oldValue;

		if (node instanceof Element nodeElement) {
			String startTime = getValueFromChild(nodeElement, F1);
			String endTime = getValueFromChild(nodeElement, F2);
			String acquisitionDuration = getValueFromChild(nodeElement, F3);

			if (!startTime.isBlank()) {
				processingTimes.setStartTime(Instant.parse(startTime));
			}
			if (!endTime.isBlank()) {
				processingTimes.setEndTime(Instant.parse(endTime));
			}
			processingTimes.setAcquisitionDuration(Duration.ofMillis(Long.parseLong(acquisitionDuration)));
			if (processingTimes.getStartTime() != null && processingTimes.getEndTime() != null) {
				processingTimes.setProcessingDuration(Duration.ofMillis(processingTimes.getEndTime().toEpochMilli() - processingTimes.getStartTime().toEpochMilli()));
			}
		}

		return processingTimes;
	}

	@Override
	public ExpandedNodeId getTypeId() {
		return TYPE_ID;
	}

	@Override
	public ExpandedNodeId getXmlEncodingId() {
		return XML_ENCODING_ID;
	}

	@Override
	public ExpandedNodeId getJsonEncodingId() {
		return ExpandedNodeId.NULL_VALUE;
	}

	public ExpandedNodeId getBinaryEncodingId() {
		return BINARY_ENCODING_ID;
	}

	@Override
	public StructureField[] getStructureField(OpcUaServer server) throws Exception {
		return new StructureField[] {getUtcTimeStructureField(F1), getUtcTimeStructureField(F2), getDurationStructureField(F3), getDurationStructureField(F4)};
	}


	public Instant getStartTime() {
		return startTime;
	}

	public void setStartTime(Instant startTime) {
		this.startTime = startTime;
	}

	public Instant getEndTime() {
		return endTime;
	}

	public void setEndTime(Instant endTime) {
		this.endTime = endTime;
	}

	public Duration getAcquisitionDuration() {
		return acquisitionDuration;
	}

	public void setAcquisitionDuration(Duration acquisitionDuration) {
		this.acquisitionDuration = acquisitionDuration;
	}

	public Duration getProcessingDuration() {
		return processingDuration;
	}

	public void setProcessingDuration(Duration processingDuration) {
		this.processingDuration = processingDuration;
	}


	public void actualizeValue(UaVariableNode node) {
		// This is empty because this method is only used in ZF Namespace
	}

	@Override
	public StructDefinition getStructDefinition() {
		return StructTypes.DT_PROCESSING_TIMES_DATA_TYPE;
	}

	@Override
	public GenericDataTypeCodec<DT_ProcessingTimesDataType> getCodec() {
		return new Codec();
	}

	@Override
	public Object toWritableValue() {
		return this;
	}

	public static class Codec extends GenericDataTypeCodec<DT_ProcessingTimesDataType> {
		@Override
		public Class<DT_ProcessingTimesDataType> getType() {
			return DT_ProcessingTimesDataType.class;
		}

		@Override
		public DT_ProcessingTimesDataType decodeType(EncodingContext context, UaDecoder decoder) throws UaSerializationException {
			Instant startTime = decoder.decodeDateTime(F1).getJavaInstant();
			Instant endTime = decoder.decodeDateTime(F2).getJavaInstant();
			Duration acquisitionTime = Duration.ofMillis(decoder.decodeDouble(F3).longValue());
			Duration processingTime = Duration.ofMillis(decoder.decodeDouble(F4).longValue());
			return new DT_ProcessingTimesDataType(startTime, endTime, acquisitionTime, processingTime);
		}

		@Override
		public void encodeType(EncodingContext context, UaEncoder encoder, DT_ProcessingTimesDataType value) throws UaSerializationException {
			encoder.encodeDateTime(F1, new DateTime(value.startTime));
			encoder.encodeDateTime(F2, new DateTime(value.endTime));
			encoder.encodeDouble(F3, (double) value.acquisitionDuration.toMillis());
			encoder.encodeDouble(F4, (double) value.processingDuration.toMillis());
		}

	}

	@Override
	public boolean equals(Object o) {
		if (this == o) {
			return true;
		}
		if (o == null || getClass() != o.getClass()) {
			return false;
		}
		DT_ProcessingTimesDataType that = (DT_ProcessingTimesDataType) o;
		return Objects.equals(startTime, that.startTime) && Objects.equals(endTime, that.endTime) && Objects.equals(acquisitionDuration, that.acquisitionDuration) && Objects.equals(processingDuration, that.processingDuration);
	}

	@Override
	public int hashCode() {
		return Objects.hash(startTime, endTime, acquisitionDuration, processingDuration);
	}

[kevinherron]

I would guess the problem is that you are simply mutating the same structure instance instead of creating new ones, and Objects.equals short circuits and treats the same instance as equal:

    /**
     * Returns {@code true} if the arguments are equal to each other
     * and {@code false} otherwise.
     * Consequently, if both arguments are {@code null}, {@code true}
     * is returned.  Otherwise, if the first argument is not {@code
     * null}, equality is determined by calling the {@link
     * Object#equals equals} method of the first argument with the
     * second argument of this method. Otherwise, {@code false} is
     * returned.
     *
     * @param a an object
     * @param b an object to be compared with {@code a} for equality
     * @return {@code true} if the arguments are equal to each other
     * and {@code false} otherwise
     * @see Object#equals(Object)
     */
    public static boolean equals(Object a, Object b) {
        return (a == b) || (a != null && a.equals(b));
    }

Generally speaking, everything in Milo is written with immutability in mind. All the built in types, all the generated structs, all the logic, etc...