Skip to content

Commit c973112

Browse files
committed
Merge branch 'master' into feature/declared-acks
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
2 parents 3bfbec1 + 248c01c commit c973112

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

java/src/main/java/org/eclipse/ditto/client/messaging/internal/WebSocketMessagingProvider.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -421,20 +421,15 @@ private WebSocket recreateWebSocket() {
421421

422422
@Override
423423
public void onBinaryMessage(final WebSocket websocket, final byte[] binary) {
424-
callbackExecutor.execute(() -> {
425-
final String stringMessage = new String(binary, StandardCharsets.UTF_8);
426-
LOGGER.debug(
427-
"Client <{}>: Received WebSocket byte array message <{}>, as string <{}> - don't know what to do" +
428-
" with it!.", sessionId, binary, stringMessage);
429-
});
424+
final String stringMessage = new String(binary, StandardCharsets.UTF_8);
425+
LOGGER.debug("Client <{}>: Received WebSocket byte array message <{}>, as string <{}> - don't know what to do" +
426+
" with it!.", sessionId, binary, stringMessage);
430427
}
431428

432429
@Override
433430
public void onTextMessage(final WebSocket websocket, final String text) {
434-
callbackExecutor.execute(() -> {
435-
LOGGER.debug("Client <{}>: Received WebSocket string message <{}>", sessionId, text);
436-
handleIncomingMessage(text);
437-
});
431+
LOGGER.debug("Client <{}>: Received WebSocket string message <{}>", sessionId, text);
432+
handleIncomingMessage(text);
438433
}
439434

440435
private void handleIncomingMessage(final String message) {

javascript/lib/node/src/node-http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class NodeRequester implements HttpRequester {
9696
host: parsedUrl.host,
9797
path: parsedUrl.pathname
9898
};
99-
if (this.proxyAgent !== undefined) {
99+
if (this.proxyAgent !== undefined && this.proxyAgent.options.path !== undefined) {
100100
request['agent'] = this.proxyAgent;
101101
}
102102
return request;

javascript/lib/node/src/node-websocket.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class NodeWebSocket implements WebSocketImplementation {
6363
const [authenticatedUrl, authenticatedHeaders] = authenticateWithUrlAndHeaders(url, new Map(), authProviders);
6464
const plainHeaders = mapToPlainObject(authenticatedHeaders);
6565
const options: ClientOptions = {
66-
agent: agent.proxyAgent,
66+
agent: agent.proxyAgent.options.path !== undefined ? agent.proxyAgent : false,
6767
rejectUnauthorized: false,
6868
headers: plainHeaders
6969
};

legal/NOTICE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ SPDX-License-Identifier: EPL-2.0
2323

2424
* Copyright 2019 Bosch Software Innovations GmbH
2525
* Copyright 2020 Bosch.IO GmbH
26+
* Copyright 2020 Zeptio AB
2627

2728
All content is the property of the respective authors or their employers.
2829
For more information regarding authorship of content, please consult the

0 commit comments

Comments
 (0)