Skip to content

Commit 389cec4

Browse files
committed
fix Java client build after upstream changes in Ditto
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
1 parent 526b34b commit 389cec4

File tree

4 files changed

+21
-8
lines changed

4 files changed

+21
-8
lines changed

java/src/main/java/org/eclipse/ditto/client/internal/AbstractHandle.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,11 @@ public Optional<JsonValue> getEntity(final JsonSchemaVersion schemaVersion) {
336336
return ack.getEntity(schemaVersion);
337337
}
338338

339+
@Override
340+
public T setEntity(final JsonValue entity) {
341+
return (T) this;
342+
}
343+
339344
@Override
340345
public T setDittoHeaders(final DittoHeaders dittoHeaders) {
341346
return (T) this;

java/src/main/java/org/eclipse/ditto/client/internal/CommonManagementImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ private CompletionStage<List<Thing>> sendRetrieveThingsMessage(final RetrieveThi
810810
@Nullable
811811
private static Thing transformModifyResponse(final CommandResponse<?> response) {
812812
if (response instanceof WithOptionalEntity) {
813-
return ((WithOptionalEntity) response).getEntity(response.getImplementedSchemaVersion())
813+
return ((WithOptionalEntity<?>) response).getEntity(response.getImplementedSchemaVersion())
814814
.filter(JsonValue::isObject)
815815
.map(JsonValue::asObject)
816816
.map(ThingsModelFactory::newThing)

java/src/main/java/org/eclipse/ditto/client/live/commands/modify/AbstractModifyLiveCommand.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
import java.util.Optional;
1616

17+
import org.eclipse.ditto.base.model.json.JsonSchemaVersion;
1718
import org.eclipse.ditto.client.live.commands.base.AbstractLiveCommand;
1819
import org.eclipse.ditto.client.live.commands.base.LiveCommand;
1920
import org.eclipse.ditto.client.live.commands.base.LiveCommandAnswerBuilder;
2021
import org.eclipse.ditto.json.JsonValue;
21-
import org.eclipse.ditto.base.model.json.JsonSchemaVersion;
2222
import org.eclipse.ditto.things.model.ThingId;
2323
import org.eclipse.ditto.things.model.signals.commands.modify.ThingModifyCommand;
2424

@@ -57,4 +57,9 @@ public Optional<JsonValue> getEntity(final JsonSchemaVersion schemaVersion) {
5757
return thingModifyCommand.getEntity(schemaVersion);
5858
}
5959

60+
@Override
61+
@SuppressWarnings("unchecked")
62+
public T setEntity(final JsonValue entity) {
63+
return (T) this;
64+
}
6065
}

java/src/main/java/org/eclipse/ditto/client/policies/internal/PoliciesImpl.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020

2121
import javax.annotation.Nonnull;
2222

23+
import org.eclipse.ditto.base.model.acks.AcknowledgementLabel;
24+
import org.eclipse.ditto.base.model.acks.DittoAcknowledgementLabel;
2325
import org.eclipse.ditto.client.internal.AbstractHandle;
2426
import org.eclipse.ditto.client.internal.OutgoingMessageFactory;
2527
import org.eclipse.ditto.client.internal.bus.PointerBus;
@@ -29,12 +31,9 @@
2931
import org.eclipse.ditto.json.JsonFieldSelector;
3032
import org.eclipse.ditto.json.JsonObject;
3133
import org.eclipse.ditto.json.JsonValue;
32-
import org.eclipse.ditto.base.model.acks.AcknowledgementLabel;
33-
import org.eclipse.ditto.base.model.acks.DittoAcknowledgementLabel;
3434
import org.eclipse.ditto.policies.model.PoliciesModelFactory;
3535
import org.eclipse.ditto.policies.model.Policy;
3636
import org.eclipse.ditto.policies.model.PolicyId;
37-
import org.eclipse.ditto.protocol.TopicPath;
3837
import org.eclipse.ditto.policies.model.signals.commands.modify.CreatePolicy;
3938
import org.eclipse.ditto.policies.model.signals.commands.modify.CreatePolicyResponse;
4039
import org.eclipse.ditto.policies.model.signals.commands.modify.DeletePolicy;
@@ -43,6 +42,7 @@
4342
import org.eclipse.ditto.policies.model.signals.commands.modify.PolicyModifyCommandResponse;
4443
import org.eclipse.ditto.policies.model.signals.commands.query.RetrievePolicy;
4544
import org.eclipse.ditto.policies.model.signals.commands.query.RetrievePolicyResponse;
45+
import org.eclipse.ditto.protocol.TopicPath;
4646

4747
/**
4848
* Default implementation for {@link Policies}.
@@ -102,9 +102,12 @@ public CompletionStage<Optional<Policy>> put(final Policy policy, final Option<?
102102
return askPolicyCommand(outgoingMessageFactory.putPolicy(policy, options),
103103
// response could be either CreatePolicyResponse or ModifyPolicyResponse.
104104
PolicyModifyCommandResponse.class,
105-
response -> response.getEntity(response.getImplementedSchemaVersion())
106-
.map(JsonValue::asObject)
107-
.map(PoliciesModelFactory::newPolicy)
105+
response -> {
106+
final Optional<JsonValue> entity = response.getEntity(response.getImplementedSchemaVersion());
107+
return entity
108+
.map(JsonValue::asObject)
109+
.map(PoliciesModelFactory::newPolicy);
110+
}
108111
);
109112
}
110113

0 commit comments

Comments
 (0)