Skip to content

Commit 4278696

Browse files
dnzxyebouchut
andauthored
Fix browser build sync and alive behavior (LoopKit#164)
* Fix browser build sync and alive behavior - Added logic to extend the alive check for the existence of either `alive-main` or `alive-dev` branches. - Resolved an issue where unexpected successes were occurring when failures were expected. - Implemented a check to determine the existence of the `alive-main` and `alive-dev` branches and create them if they do not exist. - Introduced a mechanism to identify the current branch being run (either `main` or `dev`). - Based on the current branch, the corresponding alive branch (`alive-main` or `alive-dev`) will be used to check for upstream changes. - Set a new variable `ABORT_SYNC` to `true` when the current branch is neither `dev` nor `main`. - The syncing attempt will proceed based on the `ABORT_SYNC` variable status. - Ensured proper branch synchronization to prevent build inconsistencies and failures - Addresses issue LoopKit/Loop#2192 - Updates app store connect link for validation error hints to new Apple URL scheme * 💚 Security Fix Co-Authored-By: ebouchut <ebouchut@users.noreply.github.com> --------- Co-authored-by: ebouchut <ebouchut@users.noreply.github.com>
1 parent e70136b commit 4278696

File tree

4 files changed

+219
-168
lines changed

4 files changed

+219
-168
lines changed

.github/workflows/add_identifiers.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,15 @@ jobs:
2424

2525
# Patch Fastlane Match to not print tables
2626
- name: Patch Match Tables
27-
run: find /usr/local/lib/ruby/gems -name table_printer.rb | xargs sed -i "" "/puts(Terminal::Table.new(params))/d"
28-
27+
run: |
28+
TABLE_PRINTER_PATH=$(ruby -e 'puts Gem::Specification.find_by_name("fastlane").gem_dir')/match/lib/match/table_printer.rb
29+
if [ -f "$TABLE_PRINTER_PATH" ]; then
30+
sed -i "" "/puts(Terminal::Table.new(params))/d" "$TABLE_PRINTER_PATH"
31+
else
32+
echo "table_printer.rb not found"
33+
exit 1
34+
fi
35+
2936
# Install project dependencies
3037
- name: Install Project Dependencies
3138
run: bundle install

0 commit comments

Comments
 (0)