Fix config serialization (#1187)

* Fix config serialization

We were failing to deserialize in certain situations
when there are virtual chunk containers.

This change breaks compatibility for users who wrote config
with virtual chunk containers to their repos. 

Those users will need to edit the config.yaml file adding 

```
name: null
```

to their virtual chunk containers.

Closes: #1181

* Allow missing name field for VirtualChunkContainers

* Add pickle/unpickle to stateful test

Author: paraseba

icechunk-python/tests/test_zarr/test_stateful.py

@@ -1,5 +1,6 @@
 import functools
 import json
+import pickle
 from typing import Any
 
 import hypothesis.extra.numpy as npst
@@ -345,6 +346,14 @@ def delete_dir(self, data) -> None:
         self.all_groups = self.all_groups - matches
         self.all_arrays = self.all_arrays - matches
 
+    @rule()
+    def pickle_objects(self) -> None:
+        if not self.store.session.has_uncommitted_changes:
+            session = self.store.session.fork()
+            pickle.loads(pickle.dumps(session))
+
+        pickle.loads(pickle.dumps(self.repo))
+
     @invariant()
     def check_list_prefix_from_root(self) -> None:
         model_list = self._sync_iter(self.model.list_prefix(""))

icechunk/src/config.rs

@@ -587,3 +587,87 @@ pub enum Credentials {
     Gcs(GcsCredentials),
     Azure(AzureCredentials),
 }
+
+#[cfg(test)]
+#[allow(clippy::panic, clippy::unwrap_used, clippy::expect_used)]
+mod tests {
+    use crate::{
+        ObjectStoreConfig, RepositoryConfig, config::S3Options,
+        strategies::repository_config, virtual_chunks::VirtualChunkContainer,
+    };
+
+    use proptest::prelude::*;
+
+    #[icechunk_macros::test]
+    fn test_config_serialization() {
+        let mut config = RepositoryConfig::default();
+        let bytes = rmp_serde::to_vec(&config).unwrap();
+        let roundtrip = rmp_serde::from_slice(&bytes).unwrap();
+        assert_eq!(config, roundtrip);
+
+        config.set_virtual_chunk_container(
+            VirtualChunkContainer::new(
+                "s3://foo/bar/".to_string(),
+                ObjectStoreConfig::S3(S3Options {
+                    region: Some("us-east-1".to_string()),
+                    endpoint_url: None,
+                    anonymous: false,
+                    allow_http: false,
+                    force_path_style: false,
+                    network_stream_timeout_seconds: None,
+                }),
+            )
+            .unwrap(),
+        );
+        let bytes = rmp_serde::to_vec(&config).unwrap();
+        let roundtrip = rmp_serde::from_slice(&bytes).unwrap();
+        assert_eq!(config, roundtrip);
+    }
+
+    #[icechunk_macros::test]
+    fn test_virtual_container_serialization() {
+        let container = VirtualChunkContainer::new(
+            "s3://foo/bar/".to_string(),
+            ObjectStoreConfig::S3(S3Options {
+                region: Some("us-east-1".to_string()),
+                endpoint_url: None,
+                anonymous: false,
+                allow_http: false,
+                force_path_style: false,
+                network_stream_timeout_seconds: None,
+            }),
+        )
+        .unwrap();
+        let bytes = rmp_serde::to_vec(&container).unwrap();
+        let roundtrip = rmp_serde::from_slice(&bytes).unwrap();
+        assert_eq!(container, roundtrip);
+    }
+
+    #[icechunk_macros::test]
+    fn test_object_store_config_serialization() {
+        let config = ObjectStoreConfig::S3(S3Options {
+            region: Some("us-east-1".to_string()),
+            endpoint_url: None,
+            anonymous: false,
+            allow_http: false,
+            force_path_style: false,
+            network_stream_timeout_seconds: None,
+        });
+        let bytes = rmp_serde::to_vec(&config).unwrap();
+        let roundtrip = rmp_serde::from_slice(&bytes).unwrap();
+        assert_eq!(config, roundtrip);
+    }
+
+    proptest! {
+        #![proptest_config(ProptestConfig {
+            cases: 50, .. ProptestConfig::default()
+        })]
+
+        #[icechunk_macros::test]
+        fn test_config_roundtrip(config in repository_config() ) {
+            let bytes = rmp_serde::to_vec(&config).unwrap();
+            let roundtrip = rmp_serde::from_slice(&bytes).unwrap();
+            assert_eq!(config, roundtrip);
+        }
+    }
+}