Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit c479ee1

Browse files
authored
chore: remove deprecated code for next major (#2536)
1 parent fa76831 commit c479ee1

File tree

11 files changed

+7
-568
lines changed

11 files changed

+7
-568
lines changed

.changeset/late-rats-hope.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ebay/skin": major
3+
---
4+
5+
chore: remove deprecations for next major version

dist/lightbox-dialog/lightbox-dialog.css

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -211,18 +211,6 @@ button.icon-btn.lightbox-dialog__prev {
211211
opacity: 1;
212212
transform: translateY(0);
213213
}
214-
215-
.lightbox-dialog__handle {
216-
background-color: initial;
217-
border: none;
218-
left: 0;
219-
margin: -11px auto;
220-
padding: 8px;
221-
position: relative;
222-
right: 0;
223-
top: 11px;
224-
z-index: 2;
225-
}
226214
.lightbox-dialog__handle:after {
227215
background-color: var(--dialog-handle-color, var(--color-stroke-default));
228216
border-radius: 3px;
@@ -232,11 +220,6 @@ button.icon-btn.lightbox-dialog__prev {
232220
width: 24px;
233221
}
234222

235-
.lightbox-dialog__window--expanded {
236-
height: 95%;
237-
max-height: 95%;
238-
}
239-
240223
[dir="rtl"] button.icon-btn.lightbox-dialog__prev .icon--16 {
241224
transform: rotate(180deg);
242225
}
@@ -263,20 +246,13 @@ button.icon-btn.lightbox-dialog__prev {
263246
max-width: 100%;
264247
width: 100%;
265248
}
266-
.lightbox-dialog--fullscreen .lightbox-dialog__handle,
267-
.lightbox-dialog--large .lightbox-dialog__handle {
268-
display: none;
269-
}
270249
}
271250
@media (min-width: 512px) {
272251
.lightbox-dialog__window {
273252
border-radius: var(--lightbox-border-radius, var(--border-radius-100));
274253
margin: auto;
275254
max-width: calc(88% - var(--spacing-400));
276255
}
277-
.lightbox-dialog__handle {
278-
display: none;
279-
}
280256
.lightbox-dialog--narrow .lightbox-dialog__window {
281257
max-width: var(--dialog-lightbox-narrow-max-width);
282258
}

dist/skeleton/skeleton.css

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ div.skeleton__text:not(:last-child),
114114
div.skeleton__textbox:not(:last-child) {
115115
margin-block-end: var(--spacing-150);
116116
}
117-
.skeleton--elevated {
118-
--skeleton-background: var(--color-loading-fill-elevated);
119-
}
120117

121118
.skeleton--on-secondary {
122119
--skeleton-background: var(--color-loading-fill-on-secondary);
@@ -126,9 +123,6 @@ div.skeleton__textbox:not(:last-child) {
126123
.skeleton {
127124
--skeleton-background: var(--color-loading-shimmer);
128125
}
129-
.skeleton--elevated {
130-
--skeleton-background: var(--color-loading-shimmer-elevated);
131-
}
132126
.skeleton--on-secondary {
133127
--skeleton-background: var(--color-loading-shimmer-on-secondary);
134128
}

dist/table/table.css

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,7 @@
106106
text-align: left;
107107
}
108108

109-
.table-cell--numeric {
110-
text-align: right;
111-
}
112-
.table__cell {
113-
text-align: left;
114-
}
115-
109+
.table-cell--numeric,
116110
.table__cell--numeric {
117111
text-align: right;
118112
}

src/sass/details/stories/details.stories.js

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -69,33 +69,3 @@ export const small = () => `
6969
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
7070
</details>
7171
`;
72-
73-
// Deprecated stories
74-
export const closed12pxIcon = () => `
75-
<details class="details">
76-
<summary class="details__summary">
77-
<span class="details__label">Details</span>
78-
<span class="details__icon" hidden>
79-
<svg class="icon icon--12" aria-hidden="true">
80-
<use href="#icon-chevron-down-12"></use>
81-
</svg>
82-
</span>
83-
</summary>
84-
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
85-
</details>
86-
`;
87-
88-
// Deprecated stories
89-
export const open12pxIcon = () => `
90-
<details class="details" open>
91-
<summary class="details__summary">
92-
<span class="details__label">Details</span>
93-
<span class="details__icon" hidden>
94-
<svg class="icon icon--12" aria-hidden="true">
95-
<use href="#icon-chevron-down-12"></use>
96-
</svg>
97-
</span>
98-
</summary>
99-
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
100-
</details>
101-
`;

0 commit comments

Comments
 (0)