chore: added comments to drawer and fullscreen dialog about future removal (#2540)

agliga · web-flow · commit a21d879e6fb0 · 2025-01-27T14:02:48.000-08:00
diff --git a/.changeset/curvy-experts-smell.md b/.changeset/curvy-experts-smell.md
@@ -0,0 +1,5 @@
+---
+"@ebay/skin": major
+---
+
+chore: added comment to deprecated components about their removal
diff --git a/dist/drawer-dialog/drawer-dialog.css b/dist/drawer-dialog/drawer-dialog.css
@@ -1,3 +1,4 @@
+/*! DEPRECATED COMPONENT. Will be removed next major version */
 :root {
     --dialog-scrim-color-hide: rgba(17, 24, 32, 0);
     --dialog-scrim-color-show: rgba(17, 24, 32, 0.7);
diff --git a/dist/fullscreen-dialog/fullscreen-dialog.css b/dist/fullscreen-dialog/fullscreen-dialog.css
@@ -1,3 +1,4 @@
+/*! DEPRECATED COMPONENT. Will be removed next major version */
 :root {
     --dialog-scrim-color-hide: rgba(17, 24, 32, 0);
     --dialog-scrim-color-show: rgba(17, 24, 32, 0.7);
diff --git a/src/sass/drawer-dialog/drawer-dialog.scss b/src/sass/drawer-dialog/drawer-dialog.scss
@@ -1,3 +1,5 @@
+/*! DEPRECATED COMPONENT. Will be removed next major version */
+
 @import "../variables/variables";
 @import "../mixins/private/dialog-mixins";
 @import "../mixins/private/token-mixins";
diff --git a/src/sass/fullscreen-dialog/fullscreen-dialog.scss b/src/sass/fullscreen-dialog/fullscreen-dialog.scss
@@ -1,9 +1,9 @@
+/*! DEPRECATED COMPONENT. Will be removed next major version */
+
 @import "../variables/variables";
 @import "../mixins/private/dialog-mixins";
 @import "../mixins/private/token-mixins";
 
-// DEPRECATED (whole component needs to be removed)
-
 .fullscreen-dialog[role="dialog"] {
     @include dialog-base();
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@ebay/skin": major
 +---
++
 +chore: added comment to deprecated components about their removal
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/! DEPRECATED COMPONENT. Will be removed next major version /`
`1`	`2`	`:root {`
`2`	`3`	`--dialog-scrim-color-hide: rgba(17, 24, 32, 0);`
`3`	`4`	`--dialog-scrim-color-show: rgba(17, 24, 32, 0.7);`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/! DEPRECATED COMPONENT. Will be removed next major version /`
	`2`	`+`
`1`	`3`	`@import "../variables/variables";`
`2`	`4`	`@import "../mixins/private/dialog-mixins";`
`3`	`5`	`@import "../mixins/private/token-mixins";`