Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 2f246cb

Browse files
LuLaValvaLuLaValva
authored
refactor(docs): use <base> instead of custom <anchor> (#2576)
1 parent 53d8d48 commit 2f246cb

File tree

40 files changed

+153
-156
lines changed

40 files changed

+153
-156
lines changed

‎src/components/about.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div id="about">
22
<h2>About</h2>
33
<p>Skin is a pure CSS framework, created by a team of passionate frontend engineers at eBay.</p>
4-
<p>Skin's default stylesheet represents <a href="https://playbook.ebay.com">eBay Evo</a> - eBay's evolved brand and design system - but Skin also offers <anchor href="#token-system">token-based configuration</anchor> to enable non-eBay branded experiences.</p>
4+
<p>Skin's default stylesheet represents <a href="https://playbook.ebay.com">eBay Evo</a> - eBay's evolved brand and design system - but Skin also offers <a href="#token-system">token-based configuration</a> to enable non-eBay branded experiences.</p>
55
<p>Skin adheres to the following core principals:</p>
66
<dl>
77
<dt>Accessible</dt>

‎src/components/anchor.marko‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎src/components/components-list.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import path from 'path';
55
$ const name = componentName.replace(/-([a-z])/g, function (g) { return ` ${g[1].toUpperCase()}`; });
66
$ const properName = name.charAt(0).toUpperCase() + name.slice(1);
77
<li>
8-
<anchor href=`component/${componentName}/` class="nav-link" role="menuitem">${properName}</anchor>
8+
<a href=`component/${componentName}/` class="nav-link" role="menuitem">${properName}</a>
99
</li>
1010
</for>
1111

‎src/components/site-footer.marko‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ style {
1010
<footer class="page-grid-container">
1111
<nav class="primary-nav footer-nav" aria-label="Site navigation">
1212
<ul role="menubar">
13-
<li><anchor role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</anchor></li>
13+
<li><a role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</a></li>
1414
<li><a role="menuitem" href="https://github.com/eBay/skin">Repo</a></li>
1515
<li><a role="menuitem" href="/skin/storybook">Storybook</a></li>
16-
<li><anchor role="menuitem" href="/sitemap">Sitemap</anchor></li>
16+
<li><a role="menuitem" href="/sitemap">Sitemap</a></li>
1717
</ul>
1818
</nav>
1919
Copyright &copy; 2025 eBay, Inc. All rights reserved.

‎src/components/site-header.marko‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {components} from './components.marko';
1818
</div>
1919
</button>
2020
<h1 class="app-bar__title">
21-
<anchor>${siteMeta.pageTitle}</anchor>
21+
<a>${siteMeta.pageTitle}</a>
2222
</h1>
2323
<div class="site-nav-mobile">
2424

@@ -65,7 +65,7 @@ import {components} from './components.marko';
6565
<div class="tabs__cell">
6666
<nav id="primary-nav-mobile" class="primary-nav-mobile" aria-label="Site navigation">
6767
<ul class="app-bar__links" role="menubar">
68-
<li><anchor role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</anchor></li>
68+
<li><a role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</a></li>
6969
<li><a role="menuitem" href="https://github.com/eBay/skin">Repo</a></li>
7070
<li><a role="menuitem" href="/skin/storybook">Storybook</a></li>
7171
<li><a role="menuitem" href="/sitemap">Sitemap</a></li>
@@ -99,14 +99,14 @@ import {components} from './components.marko';
9999
<nav class="examples-nav" aria-label="Guides">
100100
<ul class="modules-expander__list" role="menubar">
101101
<li>
102-
<anchor href="guide/page-grid" role="menuitem">
103-
Page Grid Use Guide</anchor>
102+
<a href="guide/page-grid" role="menuitem">
103+
Page Grid Use Guide</a>
104104
</li>
105105
<li>
106-
<anchor href="guide/skeleton" role="menuitem">Skeleton Use Guide</anchor>
106+
<a href="guide/skeleton" role="menuitem">Skeleton Use Guide</a>
107107
</li>
108108
<li>
109-
<anchor href="guide/animation" role="menuitem">Animation Guide</anchor>
109+
<a href="guide/animation" role="menuitem">Animation Guide</a>
110110
</li>
111111
</ul>
112112
</nav>
@@ -117,7 +117,7 @@ import {components} from './components.marko';
117117
</div>
118118
<nav id="primary-nav" class="primary-nav" aria-label="Site navigation">
119119
<ul class="app-bar__links" role="menubar">
120-
<li><anchor role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</anchor></li>
120+
<li><a role="menuitem" href="archive/index.html">Archive (v${siteMeta.version})</a></li>
121121
<li><a role="menuitem" href="https://github.com/eBay/skin">Repo</a></li>
122122
<li><a role="menuitem" href="/skin/storybook">Storybook</a></li>
123123
</ul>

‎src/components/site-navrail.marko‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ import {components} from './components.marko';
1212
<h2 id="navrail-guides-nav_title">Guides</h2>
1313
<ul role="menubar">
1414
<li>
15-
<anchor href="guide/page-grid" role="menuitem">Page Grid Use Guide</anchor>
15+
<a href="guide/page-grid" role="menuitem">Page Grid Use Guide</a>
1616
</li>
1717
<li>
18-
<anchor href="guide/skeleton" role="menuitem">Skeleton Use Guide</anchor>
18+
<a href="guide/skeleton" role="menuitem">Skeleton Use Guide</a>
1919
</li>
2020
<li>
21-
<anchor href="guide/animation" role="menuitem">Animation Guide</anchor>
21+
<a href="guide/animation" role="menuitem">Animation Guide</a>
2222
</li>
2323
</ul>
2424
</nav>

‎src/components/themes.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@
3030
</ul>
3131
-->
3232

33-
<p>Warning! Changing the value of any product-level token will cause a ripple effect through all skin modules. If this is not your intention, tokens are also available at the component-level. See <anchor href="component/switch#switch-variables">switch-variables</anchor> for an example.</p>
33+
<p>Warning! Changing the value of any product-level token will cause a ripple effect through all skin modules. If this is not your intention, tokens are also available at the component-level. See <a href="component/switch#switch-variables">switch-variables</a> for an example.</p>
3434
</div>

‎src/components/token-system.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<p>In order for Skin to render correctly, values for core tokens and light tokens are <strong>required</strong>.</p>
1212
<p>The easiest way to satisfy this requirement is to include one of the following bundles:</p>
1313
<ul>
14-
<li><anchor href="component/tokens/">@ebay/skin/tokens</anchor></li>
14+
<li><a href="component/tokens/">@ebay/skin/tokens</a></li>
1515
</ul>
1616

1717
<p>It is also possible for a page to roll their own tokens sets, enabling a themed or even non-eBay branded look and feel. More information will be provided in a future release.</p>

‎src/routes/_index/+layout.marko‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
static const basePath = import.meta.env.BASE_URL;
12
<!doctype html>
23
<html lang="en">
34
<head>
45
<title>${$global.meta.pageTitle || 'eBay Skin CSS Framework'}</title>
56
<meta name="description" content=`${$global.meta.pageDescription || 'The official static CSS framework of eBay - Skin is a semantic, accessible, responsive, and highly usable framework and CSS component library.'}`>
67
<meta name="viewport" content="width=device-width, initial-scale=1"/>
78
<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
9+
<base href=basePath>
810
<master-icons/>
911
<master-flags/>
1012
</head>

‎src/routes/_index/component/+page.marko‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import path from 'path';
66
<ul>
77
<for|key, folder| in=components>
88
<li>
9-
<anchor href=`component/${path.basename(folder)}/` class="module-link">${path.basename(folder)}</anchor>
9+
<a href=`component/${path.basename(folder)}/` class="module-link">${path.basename(folder)}</a>
1010
</li>
1111
</for>
1212
</ul>

0 commit comments

Comments
 (0)