Merge branch '18.4.0' of https://github.com/eBay/skin into 2457-table-iteration-3

Author: ArtBlue

.changeset/great-ways-taste.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+chore: removed unused storybook files (and percy workflow)

.changeset/proud-dodos-cover.md

@@ -0,0 +1,5 @@
+---
+"@ebay/skin": minor
+---
+
+feat(icons): added and modified icons

.github/workflows/pages-html-proofer.yml

@@ -1,16 +1,17 @@
 name: pages-html-proofer
 
-on:
-  push:
-    paths:
-      - 'docs/**'
-      - '!docs/storybook'
-      - '.github/workflows/pages-html-proofer.yml'
-  pull_request:
-    paths:
-      - 'docs/**'
-      - '!docs/storybook'
-      - '.github/workflows/pages-html-proofer.yml'
+# Disabled for now. Will re-enable once we have a better html proofer
+# on:
+#   push:
+#     paths:
+#       - 'docs/**'
+#       - '!docs/storybook'
+#       - '.github/workflows/pages-html-proofer.yml'
+#   pull_request:
+#     paths:
+#       - 'docs/**'
+#       - '!docs/storybook'
+#       - '.github/workflows/pages-html-proofer.yml'
 
 jobs:
   pages-html-proofer:
@@ -26,5 +27,5 @@ jobs:
         - run: npm run deploy:only
         - uses: chabad360/htmlproofer@master
           with:
-            directory: "./_site"
+            directory: "./_siteDev"
             arguments: --disable_external --ignore_empty_alt --allow_hash_href --allow_missing_href

.github/workflows/storybook-percy.yml

@@ -1,5 +1,6 @@
 _cdn
 _site
+_siteDev
 site
 docs/.jekyll-metadata
 node_modules

.gitignore

@@ -1,5 +1,17 @@
 # Skin Changelog
 
+## 18.3.2
+
+### Patch Changes
+
+-   [`477a4a0`](https://github.com/eBay/skin/commit/477a4a060ad322e56183caf4eb2dc5e72452e893) Thanks [@agliga](https://github.com/agliga)! - fix: reverted eek linting issue and fixed gh paths
+
+## 18.3.1
+
+### Patch Changes
+
+-   [`9bb257a`](https://github.com/eBay/skin/commit/9bb257a0137e4b1424af0d580bee4aac885bb2a3) Thanks [@agliga](https://github.com/agliga)! - fix: gh mixins path
+
 ## 18.3.0
 
 ### Minor Changes

CHANGELOG.md

@@ -125,7 +125,7 @@
     font-size: 8px;
 }
 @media not all and (-webkit-min-device-pixel-ratio: 0),
-    not all and (resolution >= 0.001dpcm) {
+    not all and (min-resolution: 0.001dpcm) {
     @supports (-webkit-appearance: none) {
         .eek__rating {
             text-shadow: none;

dist/eek/eek.css

@@ -1,197 +1,197 @@
 /* stylelint-disable no-invalid-position-at-import-rule */
 
 @mixin alert-dialog-mixin() {
-    @import "../../../dist/alert-dialog/alert-dialog.css";
+    @import "../alert-dialog/alert-dialog.css";
 }
 
 @mixin badge-mixin() {
-    @import "../../../dist/badge/badge.css";
+    @import "../badge/badge.css";
 }
 
 @mixin breadcrumbs-mixin() {
-    @import "../../../dist/breadcrumbs/breadcrumbs.css";
+    @import "../breadcrumbs/breadcrumbs.css";
 }
 
 @mixin button-mixin() {
-    @import "../../../dist/button/button.css";
+    @import "../button/button.css";
 }
 
 @mixin carousel-mixin() {
-    @import "../../../dist/carousel/carousel.css";
+    @import "../carousel/carousel.css";
 }
 
 @mixin checkbox-mixin() {
-    @import "../../../dist/checkbox/checkbox.css";
+    @import "../checkbox/checkbox.css";
 }
 
 @mixin combobox-mixin() {
-    @import "../../../dist/combobox/combobox.css";
+    @import "../combobox/combobox.css";
 }
 
 @mixin confirm-dialog-mixin() {
-    @import "../../../dist/confirm-dialog/confirm-dialog.css";
+    @import "../confirm-dialog/confirm-dialog.css";
 }
 
 @mixin cta-button-mixin() {
-    @import "../../../dist/cta-button/cta-button.css";
+    @import "../cta-button/cta-button.css";
 }
 
 @mixin drawer-dialog-mixin() {
-    @import "../../../dist/drawer-dialog/drawer-dialog.css";
+    @import "../drawer-dialog/drawer-dialog.css";
 }
 
 @mixin eek-mixin() {
-    @import "../../../dist/eek/eek.css";
+    @import "../eek/eek.css";
 }
 
 @mixin field-mixin() {
-    @import "../../../dist/field/field.css";
+    @import "../field/field.css";
 }
 
 @mixin filter-button-mixin() {
-    @import "../../../dist/filter-button/filter-button.css";
+    @import "../filter-button/filter-button.css";
 }
 
 @mixin filter-menu-mixin() {
-    @import "../../../dist/filter-menu/filter-menu.css";
+    @import "../filter-menu/filter-menu.css";
 }
 
 @mixin filter-menu-button-mixin() {
-    @import "../../../dist/filter-menu-button/filter-menu-button.css";
+    @import "../filter-menu-button/filter-menu-button.css";
 }
 
 @mixin floating-label-mixin() {
-    @import "../../../dist/floating-label/floating-label.css";
+    @import "../floating-label/floating-label.css";
 }
 
 @mixin fullscreen-dialog-mixin() {
-    @import "../../../dist/fullscreen-dialog/fullscreen-dialog.css";
+    @import "../fullscreen-dialog/fullscreen-dialog.css";
 }
 
 @mixin global-mixin() {
-    @import "../../../dist/global/global.css";
+    @import "../global/global.css";
 }
 
 @mixin icon-mixin() {
-    @import "../../../dist/icon/icon.css";
+    @import "../icon/icon.css";
 }
 
 @mixin icon-button-mixin() {
-    @import "../../../dist/icon-button/icon-button.css";
+    @import "../icon-button/icon-button.css";
 }
 
 @mixin infotip-mixin() {
-    @import "../../../dist/infotip/infotip.css";
+    @import "../infotip/infotip.css";
 }
 
 @mixin inline-notice-mixin() {
-    @import "../../../dist/inline-notice/inline-notice.css";
+    @import "../inline-notice/inline-notice.css";
 }
 
 @mixin lightbox-dialog-mixin() {
-    @import "../../../dist/lightbox-dialog/lightbox-dialog.css";
+    @import "../lightbox-dialog/lightbox-dialog.css";
 }
 
 @mixin link-mixin() {
-    @import "../../../dist/link/link.css";
+    @import "../link/link.css";
 }
 
 @mixin listbox-mixin() {
-    @import "../../../dist/listbox/listbox.css";
+    @import "../listbox/listbox.css";
 }
 
 @mixin listbox-button-mixin() {
-    @import "../../../dist/listbox-button/listbox-button.css";
+    @import "../listbox-button/listbox-button.css";
 }
 
 @mixin menu-mixin() {
-    @import "../../../dist/menu/menu.css";
+    @import "../menu/menu.css";
 }
 
 @mixin menu-button-mixin() {
-    @import "../../../dist/menu-button/menu-button.css";
+    @import "../menu-button/menu-button.css";
 }
 
 @mixin page-grid-mixin() {
-    @import "../../../dist/page-grid/page-grid.css";
+    @import "../page-grid/page-grid.css";
 }
 
 @mixin page-notice-mixin() {
-    @import "../../../dist/page-notice/page-notice.css";
+    @import "../page-notice/page-notice.css";
 }
 
 @mixin pagination-mixin() {
-    @import "../../../dist/pagination/pagination.css";
+    @import "../pagination/pagination.css";
 }
 
 @mixin panel-dialog-mixin() {
-    @import "../../../dist/panel-dialog/panel-dialog.css";
+    @import "../panel-dialog/panel-dialog.css";
 }
 
 @mixin progress-bar-mixin() {
-    @import "../../../dist/progress-bar/progress-bar.css";
+    @import "../progress-bar/progress-bar.css";
 }
 
 @mixin progress-spinner-mixin() {
-    @import "../../../dist/progress-spinner/progress-spinner.css";
+    @import "../progress-spinner/progress-spinner.css";
 }
 
 @mixin progress-stepper-mixin() {
-    @import "../../../dist/progress-stepper/progress-stepper.css";
+    @import "../progress-stepper/progress-stepper.css";
 }
 
 @mixin radio-mixin() {
-    @import "../../../dist/radio/radio.css";
+    @import "../radio/radio.css";
 }
 
 @mixin section-notice-mixin() {
-    @import "../../../dist/section-notice/section-notice.css";
+    @import "../section-notice/section-notice.css";
 }
 
 @mixin section-title-mixin() {
-    @import "../../../dist/section-title/section-title.css";
+    @import "../section-title/section-title.css";
 }
 
 @mixin select-mixin() {
-    @import "../../../dist/select/select.css";
+    @import "../select/select.css";
 }
 
 @mixin signal-mixin() {
-    @import "../../../dist/signal/signal.css";
+    @import "../signal/signal.css";
 }
 
 @mixin snackbar-dialog-mixin() {
-    @import "../../../dist/snackbar-dialog/snackbar-dialog.css";
+    @import "../snackbar-dialog/snackbar-dialog.css";
 }
 
 @mixin switch-mixin() {
-    @import "../../../dist/switch/switch.css";
+    @import "../switch/switch.css";
 }
 
 @mixin tabs-mixin() {
-    @import "../../../dist/tabs/tabs.css";
+    @import "../tabs/tabs.css";
 }
 
 @mixin textbox-mixin() {
-    @import "../../../dist/textbox/textbox.css";
+    @import "../textbox/textbox.css";
 }
 
 @mixin toast-dialog-mixin() {
-    @import "../../../dist/toast-dialog/toast-dialog.css";
+    @import "../toast-dialog/toast-dialog.css";
 }
 
 @mixin tooltip-mixin() {
-    @import "../../../dist/tooltip/tooltip.css";
+    @import "../tooltip/tooltip.css";
 }
 
 @mixin tourtip-mixin() {
-    @import "../../../dist/tourtip/tourtip.css";
+    @import "../tourtip/tourtip.css";
 }
 
 @mixin typography-mixin() {
-    @import "../../../dist/typography/typography.css";
+    @import "../typography/typography.css";
 }
 
 @mixin utility-mixin() {
-    @import "../../../dist/utility/utility.css";
+    @import "../utility/utility.css";
 }