Skip to content

Commit 3af1e4e

Browse files
committed
refactor: update ContributorCard and TopBar components for consistency and bug fix
1 parent 920b065 commit 3af1e4e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

web/src/components/contributor-card.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export function ContributorCard({
1616
<Link
1717
className="card bg-base-300 w-full sm:max-w-52 rounded-lg flex flex-row border-base-200 border-2 overflow-hidden"
1818
href={getContributorURL(contributor)}
19+
// TODO-OB: there's a bug here: when passing onClick to Link, the link no longer work as a SPA link, and instead causes a full reload of the page
1920
onClick={onClick}
2021
>
2122
<img

web/src/components/top-bar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from "react";
22
import { useMemo } from "react";
33
import { useLocation } from "react-router-dom";
44
import logoWide from "src/assets/svg/logo-wide.svg";
5-
import logoSquareExtended from "src/assets/svg/logo-square.svg";
5+
import logoSquare from "src/assets/svg/logo-square.svg";
66
import { Image } from "src/components/image";
77
import { Link } from "src/components/link";
88
import { Locale, useLocale } from "src/components/locale";
@@ -46,7 +46,7 @@ export function TopBar({ version, links }: TopBarProps): JSX.Element {
4646
<div className="bg-neutral">
4747
<div className="m-auto flex max-w-7xl flex-row gap-4 p-4 items-center">
4848
<Link href={"/"} className="flex lg:hidden">
49-
<Image className="h-9" src={logoSquareExtended} alt="DzCode i/o SVG Logo wide" />
49+
<Image className="h-9" src={logoSquare} alt="DzCode i/o SVG Logo wide" />
5050
</Link>
5151
<Link href={`https://github.com/dzcode-io/dzcode.io/releases/tag/${version}`}>
5252
{version}

0 commit comments

Comments
 (0)