-
Notifications
You must be signed in to change notification settings - Fork 76
Description
By default, endpoints exposed by GitHub codespaces are private to the current, logged in user.
This is true for any "customer-apps" that are deployed using this demo. The logged in GitHub users will (obviously) be able to access the endpoints, but try it in an Incognito mode and you won't be able to access. This is good as it follows secure by default design and ensures that the demo system isn't open to the world.
However, this is the case for our core platform services: Backstage, ArgoCD.
Now, when the platform spins up and the DT OneAgent is installed, Monaco is triggered via an Argo post sync hook to create DT synthetic tests against both Backstage and ArgoCD. These tests run from a public synthetic node which DT maintains. This, in turn, means that the synthetic tests attempting to access Backstage and ArgoCD will fail by default. This is expected behaviour.
So:
- We need to clearly document the above behaviour to avoid "it's broken" issues.
- We need to clearly document how a user resolves this in their environment.
Warning: It is technically possible to tell GitHub to set the codespaces as public by default but I strongly suggest we do not do so, as it breaks the "secure by default" design pattern and opens up who-knows-what in terms of security risks.