Removed unnecessary test, added requirements, updated circleci config

Author: RidleyLarsen

.circleci/config.yml

@@ -8,7 +8,7 @@ jobs:
     docker:
       # specify the version you desire here
       # use `-browsers` prefix for selenium tests, e.g. `3.6.1-browsers`
-      - image: circleci/python:3.6.1
+      - image: circleci/python:2.7.17
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images
@@ -30,7 +30,7 @@ jobs:
       - run:
           name: install dependencies
           command: |
-            python3 -m venv venv
+            virtualenv venv
             . venv/bin/activate
             pip install -r requirements.txt
 
@@ -53,3 +53,6 @@ jobs:
       - store_artifacts:
           path: test-reports
           destination: test-reports
+
+      - store_test_results:
+          path: test-reports

dynatademand/api.py

@@ -12,7 +12,7 @@ def __init__(self):
             raise DemandAPIError("All authentication data is required.")
         self._access_token = None
         self._refresh_token = None
-        self.base_host = os.getenv('DYNATA_DEMAND_BASE_URL', 'https://api.researchnow.com')
+        self.base_host = os.getenv('DYNATA_DEMAND_BASE_URL', default='https://api.researchnow.com')
         self.auth_base_url = '{}/auth/v1'.format(self.base_host)
         self.base_url = '{}/sample/v1'.format(self.base_host)
 

requirements.txt

@@ -0,0 +1,4 @@
+pytest==5.2.3
+pytest-runner==5.2
+requests==2.22.0
+responses==0.10.6

tests/test_authentication.py

@@ -49,17 +49,6 @@ def test_missing_password(self, mock_getenv):
         with self.assertRaises(DemandAPIError):
             DemandAPIClient()
 
-    @patch('os.getenv')
-    def test_missing_base_url(self, mock_getenv):
-        mock_getenv.side_effect = [
-            "test_client_id",
-            "test_username",
-            "test_password",
-            None
-        ]
-        with self.assertRaises(DemandAPIError):
-            DemandAPIClient()
-
 
 def api_test_url(endpoint):
     return "{}{}".format(BASE_URL, endpoint)