Skip to content

Commit 73021a3

Browse files
committed
removing PopResearch specific thingss...
1 parent fd0fd4e commit 73021a3

File tree

2 files changed

+13
-106
lines changed

2 files changed

+13
-106
lines changed

src/api.py

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@
44
import logging
55
import os
66

7-
from popresearch.models import CmixSurvey
8-
97
from .error import CmixError
10-
from .parsing import generate_survey_xml_strings_and_secondary_keys
8+
# from .parsing import generate_survey_xml_strings_and_secondary_keys
119

1210
log = logging.getLogger(__name__)
1311

@@ -321,19 +319,18 @@ def update_project(self, projectId, status=None):
321319
)
322320
return response
323321

324-
def create_survey(self, survey, wave_number=None):
322+
323+
# def create_survey(self, survey, wave_number=None):
325324
'''
326325
This function will create a survey on CMIX and set the survey's status to 'LIVE'.
327326
'''
327+
"""
328328
self.check_auth_headers()
329329
330330
log.debug('Sending Survey to new CMIX API: {}'.format(survey.name))
331331
strings_and_keys = generate_survey_xml_strings_and_secondary_keys(survey, wave_number)
332332
cmix_responses = []
333333
for secondary_key, xml_string in strings_and_keys:
334-
# Don't try to create survey if there's alread one there
335-
if CmixSurvey.objects.filter(survey=survey, secondary_key=secondary_key).exists():
336-
continue
337334
338335
# Give up after 10 tries
339336
if survey.failed_creation_attempts >= 10:
@@ -359,16 +356,7 @@ def create_survey(self, survey, wave_number=None):
359356
cmix_project_id = response_json.get('projectId')
360357
log.debug('Successfully created CMIX Survey {}.'.format(cmix_id))
361358
362-
CmixSurvey.objects.create(
363-
survey=survey,
364-
cmix_id=cmix_id,
365-
cmix_project_id=cmix_project_id,
366-
status='created',
367-
cmix_status='design',
368-
results_requested=False,
369-
secondary_key=secondary_key,
370-
)
371-
372359
self.update_project(response_json.get('projectId'), status=self.SURVEY_STATUS_DESIGN)
373360
374361
return cmix_responses
362+
"""

tests/test_api.py

Lines changed: 8 additions & 89 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@
66
import mock
77
import xml.etree.ElementTree as ElementTree
88
import xmlformatter
9-
from bs4 import BeautifulSoup
109

11-
from django.test import TestCase
10+
from bs4 import BeautifulSoup
11+
from unittest import TestCase
1212
from freezegun import freeze_time
1313

14-
from popresearch.cmix.api import CmixAPI, default_cmix_api, CMIX_SERVICES
15-
from popresearch.cmix.error import CmixError
14+
from src.api import CmixAPI, default_cmix_api, CMIX_SERVICES
15+
from src.error import CmixError
16+
1617
from popresearch.cmix.parsing.concepts import create_legacy_concept
1718
from popresearch.cmix.parsing.logic import create_page_logic
1819
from popresearch.cmix.parsing.page import create_media_page, create_question_page
@@ -22,8 +23,8 @@
2223
from popresearch.models import SURVEY_TYPE_COMPARISON, SURVEY_TYPE_CREATIVE, \
2324
SURVEY_TYPE_CUSTOM, SURVEY_TYPE_DESIGN, SURVEY_TYPE_INSTANT, \
2425
SURVEY_TYPE_FORCEDEXPOSURE, SURVEY_TYPE_TRACKING, \
25-
AmeritestImage, AmeritestRequest, CmixDataArchive, CmixSurvey, \
26-
Survey, User
26+
CmixDataArchive, CmixSurvey, \
27+
Survey
2728

2829
from .factories import SurveyFactory, UserFactory
2930

@@ -32,7 +33,7 @@ class TestCmixAPI(TestCase):
3233
def setUp(self):
3334
self.cmix_api = default_cmix_api()
3435
self.cmix_api._authentication_headers = {'Authorization': 'Bearer test'}
35-
self.user = User.objects.create(email="Pop.Engineering@dynata.com")
36+
self.user = UserFactory.create_safe()
3637
self.survey = Survey.objects.create(user=self.user, name="Test Survey")
3738
self.cmix_survey = CmixSurvey.objects.create(survey=self.survey, cmix_id=42)
3839

@@ -367,20 +368,6 @@ def setUp(self):
367368
self.creative_survey = SurveyFactory.create(
368369
user=self.user, survey_type=SURVEY_TYPE_CUSTOM, json=survey_json, status=Survey.COMPLETED)
369370

370-
with open('backend/apps/popresearch/tests/test_files/cmix/json/survey_creativepop.json', "r") as data_file:
371-
survey_json = json.load(data_file)
372-
self.creative_survey_with_ameritest = SurveyFactory.create(
373-
name="CreativePop With Ameritest Enabled", user=self.user,
374-
survey_type=SURVEY_TYPE_CREATIVE, json=survey_json, status=Survey.COMPLETED)
375-
question_id = "cjmkupdw300042a7j15mh37np"
376-
ar = AmeritestRequest.objects.create(question_id=question_id, survey=self.creative_survey_with_ameritest)
377-
AmeritestImage.objects.create(
378-
ameritest_request=ar, question_id=question_id, image_url="http://www.popresearch.com/favicon.png")
379-
AmeritestImage.objects.create(
380-
ameritest_request=ar, question_id=question_id, image_url="http://www.popresearch.com/favicon.png")
381-
AmeritestImage.objects.create(
382-
ameritest_request=ar, question_id=question_id, image_url="http://www.popresearch.com/favicon.png")
383-
384371
with open('backend/apps/popresearch/tests/test_files/cmix/json/survey_creativepop_POP-2044.json', "r") as data_file:
385372
survey_json = json.load(data_file)
386373
self.creative_survey_2044 = SurveyFactory.create(
@@ -679,19 +666,6 @@ def test_custompop_markup(self):
679666
demo_section = survey_element.find_all('section')[1]
680667
self.assertEqual(len(demo_section.find_all('page')), 9)
681668

682-
@freeze_time("2001-01-01 00:00:00")
683-
def test_creativepop_markup(self):
684-
self.maxDiff = None
685-
generated_xml = generate_survey_xml_strings_and_secondary_keys(self.creative_survey_with_ameritest)[0][1]
686-
generated_xml = self.formatter.format_string(generated_xml)
687-
generated_lines = generated_xml.splitlines()
688-
# with open('backend/apps/popresearch/tests/test_files/cmix/xml/survey_creativepop.xml', "w") as data_file:
689-
# data_file.write(generated_xml)
690-
with open('backend/apps/popresearch/tests/test_files/cmix/xml/survey_creativepop.xml', "r") as data_file:
691-
expected_xml = data_file.read()
692-
expected_lines = expected_xml.splitlines()
693-
self.helper_compare_lines(generated_lines, expected_lines)
694-
695669
@freeze_time("2001-01-01 00:00:00")
696670
def test_creativepop_markup_2044(self):
697671
self.maxDiff = None
@@ -939,61 +913,6 @@ def test_forcedexposure_markup_spanish(self):
939913
expected_lines = expected_xml.splitlines()
940914
self.helper_compare_lines(generated_lines, expected_lines)
941915

942-
@freeze_time("2001-01-01 00:00:00")
943-
def test_forcedexposure_markup_with_ameritest(self):
944-
self.maxDiff = None
945-
946-
with open(
947-
'backend/apps/popresearch/tests/test_files/cmix/json/survey_forcedexposure_ameritest.json',
948-
"r") as json_data_file:
949-
survey_json = json.load(json_data_file)
950-
forcedexposure_survey_cell = Survey.objects.create(
951-
user=self.user,
952-
name="ForcedExposure Survey Test",
953-
survey_type=SURVEY_TYPE_FORCEDEXPOSURE,
954-
json=survey_json
955-
)
956-
forcedexposure_survey_cell.id = 6
957-
forcedexposure_survey_cell.save()
958-
question_id = "cjeq1o413002q2a7j1puskr0r"
959-
ar = AmeritestRequest.objects.create(question_id=question_id, survey=forcedexposure_survey_cell, deleted=False)
960-
AmeritestImage.objects.create(
961-
ameritest_request=ar,
962-
question_id=question_id,
963-
image_url="http://www.popresearch.com/favicon.png"
964-
)
965-
966-
strings_and_keys = generate_survey_xml_strings_and_secondary_keys(forcedexposure_survey_cell)
967-
generated_key = strings_and_keys[0][0]
968-
self.assertEqual(generated_key, '0-United States')
969-
generated_xml = strings_and_keys[0][1]
970-
generated_xml = self.formatter.format_string(generated_xml)
971-
generated_lines = generated_xml.splitlines()
972-
# with open(
973-
# 'backend/apps/popresearch/tests/test_files/cmix/xml/survey_forcedexposure_ameritest.xml',
974-
# "w") as data_file:
975-
# data_file.write(generated_xml)
976-
with open('backend/apps/popresearch/tests/test_files/cmix/xml/survey_forcedexposure_ameritest.xml', "r") as data_file:
977-
expected_xml = data_file.read()
978-
expected_lines = expected_xml.splitlines()
979-
self.helper_compare_lines(generated_lines, expected_lines)
980-
981-
second_cell_generated_key = strings_and_keys[1][0]
982-
self.assertEqual(second_cell_generated_key, '1-United States')
983-
second_cell_generated_xml = strings_and_keys[1][1]
984-
second_cell_generated_xml = self.formatter.format_string(second_cell_generated_xml)
985-
second_cell_generated_lines = second_cell_generated_xml.splitlines()
986-
# with open(
987-
# 'backend/apps/popresearch/tests/test_files/cmix/xml/survey_forcedexposure_ameritest_second_cell.xml',
988-
# "w") as data_file:
989-
# data_file.write(second_cell_generated_xml)
990-
with open(
991-
'backend/apps/popresearch/tests/test_files/cmix/xml/survey_forcedexposure_ameritest_second_cell.xml',
992-
"r") as data_file:
993-
second_cell_expected_xml = data_file.read()
994-
second_cell_expected_lines = second_cell_expected_xml.splitlines()
995-
self.helper_compare_lines(second_cell_generated_lines, second_cell_expected_lines)
996-
997916
@freeze_time("2001-01-01 00:00:00")
998917
def test_comparisonpop_markup(self):
999918
self.maxDiff = None

0 commit comments

Comments
 (0)