Parallelize Alchemy Webhook Calls. (#3124)

Author: Kefancao

indexer/services/comlink/__tests__/helpers/alchemy-helpers.test.ts

@@ -202,7 +202,8 @@ describe('alchemy-helpers', () => {
 
       // Should still be called for all webhooks despite some failures
       // Failed webhooks will retry 3 times each, so: 1 + 3 + 3 + 3 + 1 + 1 = 12 calls
-      expect(mockFetch).toHaveBeenCalledTimes(12); // 5 EVM chains + 1 Solana with retries
+      // Plus 1 additional call from getKernelAddressFromECDSA for Avalanche chain = 13 calls
+      expect(mockFetch).toHaveBeenCalledTimes(13);
     });
 
     it('should handle missing EVM address', async () => {

indexer/services/comlink/src/helpers/alchemy-helpers.ts

@@ -68,29 +68,31 @@ export async function addAddressesToAlchemyWebhook(evm?: string, svm?: string):
     if (!record) {
       throw new Error(`EVM address does not exist in the database: ${evm}`);
     }
-    // Iterate over all EVM networks and register the address with each webhook
-    for (const [chainId, webhookId] of Object.entries(evmChainIdToAlchemyWebhookId)) {
-      try {
-        await registerAddressWithAlchemyWebhookWithRetry(evm, webhookId);
-        logger.info({
-          at: 'TurnkeyController#addAddressesToAlchemyWebhook',
-          message: `Successfully registered EVM address with webhook for chain ${chainId}`,
-          address: evm,
-          chainId,
-          webhookId,
-        });
-      } catch (error) {
-        logger.error({
-          at: 'TurnkeyController#addAddressesToAlchemyWebhook',
-          message: `Failed to register EVM address with webhook for chain ${chainId} after retries`,
-          error,
-          address: evm,
-          chainId,
-          webhookId,
-        });
-        errors.push(`Failed to register EVM address with webhook for chain ${chainId} after retries`);
-      }
-    }
+    // Register the address with all EVM webhooks in parallel
+    await Promise.allSettled(
+      Object.entries(evmChainIdToAlchemyWebhookId).map(async ([chainId, webhookId]) => {
+        try {
+          await registerAddressWithAlchemyWebhookWithRetry(evm, webhookId);
+          logger.info({
+            at: 'TurnkeyController#addAddressesToAlchemyWebhook',
+            message: `Successfully registered EVM address with webhook for chain ${chainId}`,
+            address: evm,
+            chainId,
+            webhookId,
+          });
+        } catch (error) {
+          logger.error({
+            at: 'TurnkeyController#addAddressesToAlchemyWebhook',
+            message: `Failed to register EVM address with webhook for chain ${chainId} after retries`,
+            error,
+            address: evm,
+            chainId,
+            webhookId,
+          });
+          errors.push(`Failed to register EVM address with webhook for chain ${chainId} after retries`);
+        }
+      }),
+    );
   }
 
   // Add SVM address to webhook for monitoring