Issues in importing library and running example

[gesteur]

Hello,

thanks for sharing this library which can be really useful. I was struggling a bit with the installation, first I'm not sure the dependency is on maven repo, so I have installed it locally and was able to compile the example java program.
Compiling locally there were some issues as the version of the parent 2.0.0 in pom.xml is not on the repo, so had to change with version 3.0.1.
Also to get it compiling I had to specify the following dependency
<groupId>ch.dvbern.oss.iso20022</groupId> <artifactId>iso20022-ch-intf</artifactId> <version>4.3.0-SNAPSHOT</version>

because with artifactId iso20022-impl the test example didnt resolve Pain001Service and other classes.

can you please confirm that these are the correct steps?
After the above mentioned changes, I managed to get the library compiled and also calling it from a test class using the example provided with MyCDIEnabledClass, however when I run it, I get an NPE . (classNotFoundException)
the issues is with this method pain001Service.getPainFileContent, if I comment it I can execute the program, of course without any XML created.

[gesteur]

I solved the issue, will document it here if anyone else incurs in the same issues,
first in the example pom.xml the following needs to be added, I dont know why since i'm not using StringUtils in the calling class, but StringUtils used in the pain001Service is giving issues. I'm not a java expert so happy for someone to clarify this :)
<dependency> <groupId>org.apache.commons</groupId> <artifactId>commons-lang3</artifactId> <version>3.8.1</version> </dependency>

Secondly I managed to make the code run by instantiating the class like this:
Pain001V00103CH02Service pain001Service = new Pain001V00103CH02Service();
with the Inject annotation, i get the class not found exception.

I also would like to point out that there is a mismatch between the clearing Number setZahlungsempfaegerBankClearingNumber and what is set in the Example. In the example a BIC code is used, which is also enforced by the lib, cannot be null.

iso20022/iso20022-ch-impl/src/main/java/ch/dvbern/oss/lib/iso20022/pain001/v00103ch02/Pain001V00103CH02Service.java

Line 205 in f0bcf8a

requireNonNull(auszahlungDTO.getZahlungsempfaegerBankClearingNumber(), "BIC is required");

Usually setting the BIC makes more sense than the Clearing Number, those 2 are not the same. Further for the Credit Agent if the IBAN is present (and it should be mandatory) then the BIC or the Clearing Number are not necessary. This for payments in CH/LI.
So the above null condition should be ommitted in case an IBAN is set.