PCE: Fixed possible issues when loading state

A mismatch might happen in the future if we resize an integer or increase the system memory.

Now we check that block.len is what we expect.
- If it is smaller than expected, we pad the rest with zeroes (little endian casting).
- If it is bigger, we crop it.

Author: ducalex

base.cmake

@@ -2,18 +2,6 @@ include($ENV{IDF_PATH}/tools/cmake/project.cmake)
 set(EXTRA_COMPONENT_DIRS "${CMAKE_CURRENT_LIST_DIR}/components")
 set(SDKCONFIG_DEFAULTS "${CMAKE_CURRENT_LIST_DIR}/base.sdkconfig")
 
-execute_process(
-  COMMAND git describe --tags --abbrev=5 --long --dirty=*
-  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-  OUTPUT_VARIABLE PROJECT_VER
-  OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-
-if(NOT PROJECT_VER)
-    string(TIMESTAMP TODAY "%Y.%m.%d")
-    set(PROJECT_VER "${TODAY}-nogit")
-endif()
-
 macro(rg_setup_compile_options)
     set(RG_TARGET "RG_TARGET_$ENV{RG_TARGET}")
     message("Target: ${RG_TARGET}")

components/retro-go/component.mk

@@ -11,9 +11,7 @@
 #include "pce.h"
 
 /**
- * Describes what is saved in a save state. Changing the order will break
- * previous saves so add a place holder if necessary. Eventually we could use
- * the keys to make order irrelevant...
+ * Save state file description.
  */
 #define SVAR_1(k, v) { {k, 1, 1}, &v }
 #define SVAR_2(k, v) { {k, 2, 2}, &v }
@@ -341,11 +339,16 @@ LoadState(const char *name)
 		{
 			if (strncmp(var->desc.key, block.key, 12) == 0)
 			{
-				if (!fread(var->ptr, var->desc.len, 1, fp))
+				size_t len = MIN((size_t)var->desc.len, (size_t)block.len);
+				if (!fread(var->ptr, len, 1, fp))
 				{
 					MESSAGE_ERROR("fread error reading block data\n");
 					goto _cleanup;
 				}
+				if (len < var->desc.len)
+				{
+					memset(var->ptr + len, 0, var->desc.len - len);
+				}
 				MESSAGE_INFO("Loaded %s\n", var->desc.key);
 				break;
 			}