Drop support for make build system

Author: ducalex

README.md

@@ -88,7 +88,7 @@ The official esp-idf version 3.3 or 4.0 is required and it is recommended to app
 sdcard-fix patch located in the tools folder. Both make and cmake are supported.
 
 ## Build everything and generate .fw:
-1. `python rg_tool.py build-fw` or `python rg_tool.py build-fw --use-make` (legacy make system)
+1. `python rg_tool.py build-fw`
 
 For a smaller build you can also specify which apps you want, for example the launcher + nes/gameboy only:
 1. `python rg_tool.py build-fw retro-go nofrendo-go gnuboy-go`

base.make

@@ -177,7 +177,7 @@ static bool advanced_settings_cb(odroid_dialog_choice_t *option, odroid_dialog_e
    if (event == ODROID_DIALOG_ENTER) {
       odroid_dialog_choice_t options[] = {
         {101, "Set clock", "00:00", 1, &rtc_update_cb},
-        {102, "Save SRAM", "No", 1, &save_sram_update_cb},
+        {102, "Auto save SRAM", "No", 1, &save_sram_update_cb},
         ODROID_DIALOG_CHOICE_LAST
       };
       odroid_overlay_dialog("Advanced", options, 0);
@@ -270,7 +270,7 @@ void app_main(void)
         {
             if (ram.sram_dirty)
             {
-                saveSRAM_Timer = 90;
+                saveSRAM_Timer = 120; // wait 2 seconds
                 ram.sram_dirty = 0;
             }
 

gnuboy-go/Makefile

@@ -128,17 +128,14 @@ def clean_app(target):
         print("Nothing to do.\n")
 
 
-def build_app(target, use_make=False, with_debugging=False, with_profiling=False, with_netplay=False):
+def build_app(target, with_debugging=False, with_profiling=False, with_netplay=False):
     # To do: clean up if any of the flags changed since last build
     print("Building app '%s'" % target)
     os.chdir(os.path.join(PRJ_PATH, target))
     os.putenv("ENABLE_PROFILING", "1" if with_profiling else "0")
     os.putenv("ENABLE_DEBUGGING", "1" if with_debugging else "0")
     os.putenv("ENABLE_NETPLAY", "1" if with_netplay else "0")
-    if use_make:
-        subprocess.run(["make", "-j", "6", "app"], shell=True, check=True)
-    else:
-        subprocess.run(["idf.py", "app"], shell=True, check=True)
+    subprocess.run(["idf.py", "app"], shell=True, check=True)
 
     print("Patching esp_image_header_t to skip sha256 on boot...")
     with open("build/" + target + ".bin", "r+b") as fp:
@@ -247,9 +244,6 @@ def monitor_app(target, port, baudrate=115200):
 parser.add_argument(
     "targets", nargs="*", default="all", choices=["all"] + list(PROJECT_APPS.keys())
 )
-parser.add_argument(
-    "--use-make", action="store_const", const=True, help="Use legacy make build system"
-)
 parser.add_argument(
     "--compact-fw", action="store_const", const=True, help="Ignore the partition sizes set in rg_config.py when building .fw"
 )
@@ -281,12 +275,12 @@ def monitor_app(target, port, baudrate=115200):
 if command == "build-fw":
     for target in targets:
         clean_app(target)
-        build_app(target, args.use_make, args.with_debugging, args.with_profiling, args.with_netplay)
+        build_app(target, args.with_debugging, args.with_profiling, args.with_netplay)
     build_firmware(targets)
 
 if command == "build":
     for target in targets:
-        build_app(target, args.use_make, args.with_debugging, args.with_profiling, args.with_netplay)
+        build_app(target,args.with_debugging, args.with_profiling, args.with_netplay)
 
 if command == "clean":
     for target in targets:
@@ -300,7 +294,7 @@ def monitor_app(target, port, baudrate=115200):
     monitor_app(targets[0], args.port)
 
 if command == "run":
-    build_app(targets[0], args.use_make, args.with_debugging, args.with_profiling, args.with_netplay)
+    build_app(targets[0], args.with_debugging, args.with_profiling, args.with_netplay)
     flash_app(targets[0], args.port, find_app(targets[0], args.offset, args.app_offset))
     monitor_app(targets[0], args.port)