Merge pull request #433 from dtolnay/clippy

Run clippy on test suite in CI

Author: dtolnay

.github/workflows/ci.yml

@@ -92,4 +92,4 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: dtolnay/rust-toolchain@clippy
-      - run: cargo clippy --workspace -- -Dclippy::all
+      - run: cargo clippy --workspace --tests -- -Dclippy::all

gen/lib/tests/test.rs

@@ -16,8 +16,8 @@ fn test_positive() {
     };
     let opt = Opt::default();
     let code = cxx_gen::generate_header_and_cc(rs, &opt).unwrap();
-    assert!(code.header.len() > 0);
-    assert!(code.implementation.len() > 0);
+    assert!(!code.header.is_empty());
+    assert!(!code.implementation.is_empty());
 }
 
 #[test]

tests/cxx_gen.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::field_reassign_with_default)]
+
 use cxx_gen::{generate_header_and_cc, Opt};
 use std::str;
 

tests/test.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::assertions_on_constants, clippy::float_cmp, clippy::unit_cmp)]
+
 use cxx_test_suite::extra::ffi2;
 use cxx_test_suite::ffi;
 use std::cell::Cell;