theme settings page submission errors #183
Description
Situation:
In logo image settings 'Use the default logo' is checked therefore the rest of the fieldset is hidden, however if there is still a value in the 'Path to custom logo' field then we fail validation with The custom logo path is invalid. Despite this error when the form reloads the fieldset is collapsed, obscuring the highlighted error field.
Solution:
• Add extra logic to the validation hook to ignore a value in the text field if the checkbox is checked.
• When rebuilding the form after failing validation we need to expand field sets if there are errors in fields inside them.
Bonus points:
The same issue is happening with 'shortcut icon settings' fieldset as well.
@pirog can you eyeball this just in case there's some prior knowledge that I'm missing out on here?