Skip to content

Unhandled error when storing access token in OAuthImpl #443

@ivanrein

Description

@ivanrein

Our users have been reporting issues where they keep getting signed out of Dropbox after quitting the app and relaunching.
This is how we're doing our setup and auth:

  1. on app launch, DropboxClientsManager.setupWithAppKey(.apiKey) is called
  2. sign in using DropboxClientsManager.authorizeFromControllerV2
  3. call DropboxClientsManager.handleRedirectURL
  4. now DropboxClientsManager.authorizedClient is not nil.
  5. on next app launch, we call DropboxClientsManager.setupWithAppKey(.apiKey) again, but DropboxClientsManager.authorizedClient is still nil for some users.

after further digging into handleRedirectURL call, I found this line where result of storeAccessToken is ignored. In the case of storeAccessToken returns false, the access token is not persisted for next app launch.
This could mean that for those problematic users, after calling DropboxClientsManager.setupWithAppKey(.apiKey), it may fail to setup authorizedClient in this line.
I can't verify this though or inform users why it fails since there's no logging visible from my app. Could someone help?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions