Some fascinating new compile errors on ubuntu 17.04

[fnoop]

g++ -I./util -I./ini -I./ini/cpp -Ijsoncpp -I. -std=c++11 -O2 -g -DGIT_VERSION=\"38fc\"  -Wall -Werror -Wextra -Wunused -Wredundant-decls -D_FORTIFY_SOURCE=2 -Wfloat-equal -fstack-protector -Wformat
 -Werror=format-security -Werror=pointer-arith -Wpedantic -Wlogical-op     -c -o dataflash_textdump_reader.o dataflash_textdump_reader.cpp
dataflash_textdump_reader.cpp: In member function ‘void DataFlash_TextDump_Reader::handle_line(const uint8_t*, uint32_t)’:
dataflash_textdump_reader.cpp:88:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
             value_integer *= 100;
             ~~~~~~~~~~~~~~^~~~~~
dataflash_textdump_reader.cpp:89:9: note: here
         case 'I':
         ^~~~
dataflash_textdump_reader.cpp:98:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
             value_integer *= 100;
             ~~~~~~~~~~~~~~^~~~~~
dataflash_textdump_reader.cpp:99:9: note: here
         case 'i':
         ^~~~
dataflash_textdump_reader.cpp:104:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
             value_integer *= 100;
             ~~~~~~~~~~~~~~^~~~~~
dataflash_textdump_reader.cpp:105:9: note: here
         case 'h':
         ^~~~
dataflash_textdump_reader.cpp:110:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
             value_integer *= 100;
             ~~~~~~~~~~~~~~^~~~~~
dataflash_textdump_reader.cpp:111:9: note: here
         case 'H':
         ^~~~
cc1plus: all warnings being treated as errors
<builtin>: recipe for target 'dataflash_textdump_reader.o' failed
make: *** [dataflash_textdump_reader.o] Error 1
make: *** Waiting for unfinished jobs....

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.2.0-8ubuntu3' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.2.0 (Ubuntu 7.2.0-8ubuntu3)

[peterbarker]

On Tue, 31 Oct 2017, Fnoop wrote: g++ -I./util -I./ini -I./ini/cpp -Ijsoncpp -I. -std=c++11 -O2 -g -DGIT_VERSI ON=\"38fc\" -Wall -Werror -Wextra -Wunused -Wredundant-decls -D_FORTIFY_SOU RCE=2 -Wfloat-equal -fstack-protector -Wformat -Werror=format-security -Werror=pointer-arith -Wpedantic -Wlogical-op - c -o dataflash_textdump_reader.o dataflash_textdump_reader.cpp dataflash_textdump_reader.cpp: In member function ‘void DataFlash_TextDump_R eader::handle_line(const uint8_t*, uint32_t)’: dataflash_textdump_reader.cpp:88:27: error: this statement may fall through [-Werror=implicit-fallthrough=]

*sigh*. I'm starting to reconsider this whole -Wpedantic thing :-) Could you test this branch, please? https://github.com/peterbarker/dronekit-la/tree/compilation-changes Works on my Pi and under clang++ and g++ on my Ubuntu 17.04 here.

[fnoop]

Sorry it wasn't 17.04 it was 17.10. I've killed that VM, will test again in the next day or two.