Improve the deserialization support by making the extension point consistent #148
drmohundro
started this conversation in
Ideas
Replies: 1 comment
-
See PR up at #259. It should resolve this. I've renamed |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It is difficult to know when to implement
XMLElementDeserializable
versusXMLIndexerDeserializable
. From the perspective of someone implementing custom deserialization, the indexer is for nodes that have child elements (i.e. a class with properties). Element deserialization is almost always for individual nodes (i.e. strings, ints, dates, etc.).It'd be great to make these consistent. This has also been brought up as a point of difficulty and confusion in the library itself.
See https://stackoverflow.com/questions/45851987/deserialisation-error-with-swxmlhash as an example of the confusion.
(see also #84)
Beta Was this translation helpful? Give feedback.
All reactions