Skip to content

Commit 9dc92cc

Browse files
samitolvanenmemfrob
authored andcommitted
Revert "ThinLTO: Fix inline assembly references to static functions with CFI"
This reverts commit 8e3b5cb39eef462943ed7556469604ce25c07a1d. Reverting to investigate test failures.
1 parent 1272c06 commit 9dc92cc

File tree

5 files changed

+0
-37
lines changed

5 files changed

+0
-37
lines changed

llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ void promoteInternals(Module &ExportM, Module &ImportM, StringRef ModuleId,
5555
}
5656
}
5757

58-
std::string OldName = Name.str();
5958
std::string NewName = (Name + ModuleId).str();
6059

6160
if (const auto *C = ExportGV.getComdat())
@@ -70,13 +69,6 @@ void promoteInternals(Module &ExportM, Module &ImportM, StringRef ModuleId,
7069
ImportGV->setName(NewName);
7170
ImportGV->setVisibility(GlobalValue::HiddenVisibility);
7271
}
73-
74-
if (Function *F = dyn_cast<Function>(&ExportGV)) {
75-
// Create a local alias with the original name to avoid breaking
76-
// references from inline assembly.
77-
std::string Alias = ".set " + OldName + "," + NewName + "\n";
78-
ExportM.appendModuleInlineAsm(Alias);
79-
}
8072
}
8173

8274
if (!RenamedComdats.empty())

llvm/test/ThinLTO/X86/devirt2.ll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,10 @@
131131
; RUN: -r=%t1.o,_ZN1D1mEi, \
132132
; RUN: -r=%t1.o,test2, \
133133
; RUN: -r=%t2.o,_ZN1A1nEi,p \
134-
; RUN: -r=%t2.o,_ZN1A1nEi, \
135134
; RUN: -r=%t2.o,_ZN1B1fEi,p \
136135
; RUN: -r=%t2.o,_ZN1C1fEi,p \
137136
; RUN: -r=%t2.o,_ZN1D1mEi,p \
138137
; RUN: -r=%t2.o,_ZN1E1mEi,p \
139-
; RUN: -r=%t2.o,_ZN1E1mEi, \
140138
; RUN: -r=%t2.o,_ZTV1B, \
141139
; RUN: -r=%t2.o,_ZTV1C, \
142140
; RUN: -r=%t2.o,_ZTV1D, \
@@ -169,12 +167,10 @@
169167
; RUN: -r=%t1.o,_ZN1D1mEi, \
170168
; RUN: -r=%t1.o,test2, \
171169
; RUN: -r=%t2.o,_ZN1A1nEi,p \
172-
; RUN: -r=%t2.o,_ZN1A1nEi, \
173170
; RUN: -r=%t2.o,_ZN1B1fEi,p \
174171
; RUN: -r=%t2.o,_ZN1C1fEi,p \
175172
; RUN: -r=%t2.o,_ZN1D1mEi,p \
176173
; RUN: -r=%t2.o,_ZN1E1mEi,p \
177-
; RUN: -r=%t2.o,_ZN1E1mEi, \
178174
; RUN: -r=%t2.o,_ZTV1B, \
179175
; RUN: -r=%t2.o,_ZTV1C, \
180176
; RUN: -r=%t2.o,_ZTV1D, \

llvm/test/Transforms/ThinLTOBitcodeWriter/cfi-icall-static-inline-asm.ll

Lines changed: 0 additions & 21 deletions
This file was deleted.

llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
; RUN: llvm-bcanalyzer -dump %t0 | FileCheck --check-prefix=BCA0 %s
88
; RUN: llvm-bcanalyzer -dump %t1 | FileCheck --check-prefix=BCA1 %s
99

10-
target triple = "x86_64-unknown-linux-gnu"
11-
1210
; ERROR: llvm-modextract: error: module index out of range; bitcode file contains 2 module(s)
1311

1412
; BCA0: <GLOBALVAL_SUMMARY_BLOCK

llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
; RUN: llvm-modextract -b -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=M0 %s
33
; RUN: llvm-modextract -b -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=M1 %s
44

5-
target triple = "x86_64-unknown-linux-gnu"
6-
75
define [1 x i8*]* @source() {
86
ret [1 x i8*]* @g
97
}

0 commit comments

Comments
 (0)