Skip to content

Commit 5b724c3

Browse files
JonChesterfieldmemfrob
authored andcommitted
[libomptarget][devicertl] Remove branches around setting parallelLevel
Simplifies control flow to allow store/load forwarding This change folds two basic blocks into one, leaving a single store to parallelLevel. This is a step towards spmd kernels with sufficiently aggressive inlining folding the loads from parallelLevel and thus discarding the nested parallel handling when it is unused. Transform: ``` int threadId = GetThreadIdInBlock(); if (threadId == 0) { parallelLevel[0] = expr; } else if (GetLaneId() == 0) { parallelLevel[GetWarpId()] = expr; } // => if (GetLaneId() == 0) { parallelLevel[GetWarpId()] = expr; } // because unsigned GetLaneId() { return GetThreadIdInBlock() & (WARPSIZE - 1);} // so whenever threadId == 0, GetLaneId() is also 0. ``` That replaces a store in two distinct basic blocks with as single store. A more aggressive follow up is possible if the threads in the warp/wave race to write the same value to the same address. This is not done as part of this change. ``` if (GetLaneId() == 0) { parallelLevel[GetWarpId()] = expr; } // => parallelLevel[GetWarpId()] = expr; // because unsigned GetWarpId() { return GetThreadIdInBlock() / WARPSIZE; } // so GetWarpId will index the same element for every thread in the warp // and, because expr is lane-invariant in this case, every lane stores the // same value to this unique address ``` Reviewed By: tianshilei1992 Differential Revision: https://reviews.llvm.org/D105699
1 parent a181b0f commit 5b724c3

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

openmp/libomptarget/deviceRTLs/common/src/omptarget.cu

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,13 @@ static void __kmpc_spmd_kernel_init(bool RequiresFullRuntime) {
9090
int threadId = GetThreadIdInBlock();
9191
if (threadId == 0) {
9292
usedSlotIdx = __kmpc_impl_smid() % MAX_SM;
93-
parallelLevel[0] =
94-
1 + (GetNumberOfThreadsInBlock() > 1 ? OMP_ACTIVE_PARALLEL_LEVEL : 0);
95-
} else if (GetLaneId() == 0) {
93+
}
94+
95+
if (GetLaneId() == 0) {
9696
parallelLevel[GetWarpId()] =
9797
1 + (GetNumberOfThreadsInBlock() > 1 ? OMP_ACTIVE_PARALLEL_LEVEL : 0);
9898
}
99+
99100
__kmpc_data_sharing_init_stack();
100101
if (!RequiresFullRuntime)
101102
return;

0 commit comments

Comments
 (0)