refactor: Give up on using ABSL_GUARDED_BY

Signed-off-by: Stepan Bagritsevich <stefan@dragonflydb.io>

Author: BagritsevichStepan

src/server/snapshot.cc

@@ -65,8 +65,7 @@ bool SliceSnapshot::IsSnaphotInProgress() {
   return tl_slice_snapshots.size() > 0;
 }
 
-void SliceSnapshot::Start(bool stream_journal, const Cancellation* cll, SnapshotFlush allow_flush)
-    ABSL_LOCKS_EXCLUDED(big_value_mu_) {
+void SliceSnapshot::Start(bool stream_journal, const Cancellation* cll, SnapshotFlush allow_flush) {
   DCHECK(!snapshot_fb_.IsJoinable());
 
   auto db_cb = absl::bind_front(&SliceSnapshot::OnDbChange, this);
@@ -82,16 +81,15 @@ void SliceSnapshot::Start(bool stream_journal, const Cancellation* cll, Snapshot
   const auto flush_threshold = ServerState::tlocal()->serialization_max_chunk_size;
   std::function<void(size_t, RdbSerializer::FlushState)> flush_fun;
   if (flush_threshold != 0 && allow_flush == SnapshotFlush::kAllow) {
-    flush_fun =
-        [this, flush_threshold](size_t bytes_serialized, RdbSerializer::FlushState flush_state)
-            ABSL_LOCKS_EXCLUDED(big_value_mu_) {
-              if (bytes_serialized > flush_threshold) {
-                size_t serialized = FlushSerialized(flush_state);
-                VLOG(2) << "FlushSerialized " << serialized << " bytes";
-                auto& stats = ServerState::tlocal()->stats;
-                ++stats.big_value_preemptions;
-              }
-            };
+    flush_fun = [this, flush_threshold](size_t bytes_serialized,
+                                        RdbSerializer::FlushState flush_state) {
+      if (bytes_serialized > flush_threshold) {
+        size_t serialized = FlushSerialized(flush_state);
+        VLOG(2) << "FlushSerialized " << serialized << " bytes";
+        auto& stats = ServerState::tlocal()->stats;
+        ++stats.big_value_preemptions;
+      }
+    };
   }
   serializer_ = std::make_unique<RdbSerializer>(compression_mode_, flush_fun);
 
@@ -104,8 +102,7 @@ void SliceSnapshot::Start(bool stream_journal, const Cancellation* cll, Snapshot
   });
 }
 
-void SliceSnapshot::StartIncremental(Context* cntx, LSN start_lsn)
-    ABSL_LOCKS_EXCLUDED(big_value_mu_) {
+void SliceSnapshot::StartIncremental(Context* cntx, LSN start_lsn) {
   serializer_ = std::make_unique<RdbSerializer>(compression_mode_);
 
   snapshot_fb_ = fb2::Fiber("incremental_snapshot", [cntx, start_lsn, this] {

src/server/snapshot.h

@@ -61,15 +61,14 @@ class SliceSnapshot {
   enum class SnapshotFlush { kAllow, kDisallow };
 
   void Start(bool stream_journal, const Cancellation* cll,
-             SnapshotFlush allow_flush = SnapshotFlush::kDisallow)
-      ABSL_LOCKS_EXCLUDED(big_value_mu_);
+             SnapshotFlush allow_flush = SnapshotFlush::kDisallow);
 
   // Initialize a snapshot that sends only the missing journal updates
   // since start_lsn and then registers a callback switches into the
   // journal streaming mode until stopped.
   // If we're slower than the buffer and can't continue, `Cancel()` is
   // called.
-  void StartIncremental(Context* cntx, LSN start_lsn) ABSL_LOCKS_EXCLUDED(big_value_mu_);
+  void StartIncremental(Context* cntx, LSN start_lsn);
 
   // Finalizes journal streaming writes. Only called for replication.
   // Blocking. Must be called from the Snapshot thread.
@@ -114,7 +113,7 @@ class SliceSnapshot {
   // Helper function that flushes the serialized items into the RecordStream.
   // Can block.
   using FlushState = SerializerBase::FlushState;
-  size_t FlushSerialized(FlushState flush_state) ABSL_EXCLUSIVE_LOCKS_REQUIRED(big_value_mu_);
+  size_t FlushSerialized(FlushState flush_state);  // ABSL_EXCLUSIVE_LOCKS_REQUIRED(big_value_mu_)
 
  public:
   uint64_t snapshot_version() const {
@@ -144,7 +143,7 @@ class SliceSnapshot {
   DbSlice* db_slice_;
   const DbTableArray db_array_;
 
-  std::unique_ptr<RdbSerializer> serializer_ ABSL_GUARDED_BY(big_value_mu_);
+  std::unique_ptr<RdbSerializer> serializer_;  // ABSL_GUARDED_BY(big_value_mu_);
 
   // collected during atomic bucket traversal
   std::vector<DelayedEntry> delayed_entries_ ABSL_GUARDED_BY(big_value_mu_);