Skip to content

The date format can lead to invalid dates generation #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rlouf opened this issue Jan 28, 2025 · 0 comments
Open

The date format can lead to invalid dates generation #154

rlouf opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working json schema

Comments

@rlouf
Copy link
Member

rlouf commented Jan 28, 2025 •
edited
Loading

The regex we currently use can lead to invalid dates, such as 2022-02-31. This StackOverflow post gives a regex that takes leap years into account. Not sure we want to do this as the compilation time would increase, and may want to rely on the LLM instead. At the very least we should add a comment in the code.

Note that RF3339 is quite ambiguous about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working json schema
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torymur @rlouf