-
Notifications
You must be signed in to change notification settings - Fork 136
[internal/9.0.1xx] VMR Sync failing to synchronize repo sdk #5207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ellahathaway, Can you help invest? TIA |
Looks like a CRLF issue caused by dotnet/runtime#115413. Not sure what the fix is here... darc may have to be updated to handle these LE differences. |
@dotnet/prodconsvcs - Can you provide guidance? TIA |
Is this urgent? As in - do we need a workaround asap? From seeing similar things before, I believe what is happening is that the sync runs through just fine, except at the very end, when it tries to merge branches, the working tree is dirty because there are files with non-standard EOLs that were just checked out dirty (git does that sometimes, maybe you've experienced that). @ellahathaway do you have a unix machine at hand? I would be good to try to run the sync manually using newest
I wonder if newest darc resolves this. Then we could bump darc in the internal release branch and unblock the sync that way. Alternatively, if we need the workaround asap, I can try to run this on Windows and open a manual PR against the |
I was able to successfully run the sync on my unix machine with the newest darc. The only hiccup was that the version of darc that I used doesn't support So maybe we bump darc internally and unblock that way? |
We realized today that this is unfortunately blocking the next release, so this is now urgent. I've pinged FR for guidance on this, but I'm also responding here for visibility. cc @dotnet/prodconsvcs |
@MichaelSimons How valuable is https://github.com/dotnet/dotnet/blob/release/9.0.1xx/Components.md? If it's needed, we'll need to re-introduce the option to Darc, which was removed way back in December. |
I don't see it as important. All of the info exists in other places if needed (e.g. git-info and .gitmodules. |
I manually worked around the darc issue, so I think that we can close this. If there's a different reason to keep the issue open, please feel free to re-open it. |
https://dev.azure.com/dnceng/internal/_build/results?buildId=2711871&view=logs&j=ac868591-5f39-5047-4b1f-0ffa6f6c3268&t=e582a637-0017-55a1-7459-349c940b3ec9 (internal Microsoft link)
The text was updated successfully, but these errors were encountered: