Skip to content

Consider removing detect-binaries.sh script #5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellahathaway opened this issue May 16, 2025 · 1 comment
Closed

Consider removing detect-binaries.sh script #5203

ellahathaway opened this issue May 16, 2025 · 1 comment

Comments

@ellahathaway
Copy link
Member

See dotnet/dotnet#553 (comment)

We should consider removing the stand-alone detect-binaries.sh script now that its detection functionality has been integrated into the build process. This change would simplify the workflow, improve speed, and enhance cross-platform support. The original script was created to help distro maintainers detect and remove binaries, but if that support is no longer needed via script functionality, we should remove the script and integrate the cleaning of binaries into the source-build build process as well.

@MichaelSimons
Copy link
Member

[Triage] We should preserve the logic to remove binaries with the prep script which depends on detect-binaries.sh.

@MichaelSimons MichaelSimons closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants