-
Notifications
You must be signed in to change notification settings - Fork 136
Remove reference packages from source build artifacts #4930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
[Triage] It turns out the reference packages are required during source build initialization. For example they are required to build the msbuild tasks. @ViktorHofer has an idea on how we could eliminate the dependency by using n-1 artifacts. Assigning to him as he was going to create a POC of this. If this doesn't prove out, we should just close this. The benefits are relatively low given how small the source build reference packages are these days (~25 MB). this comment](#4930 (comment)) was address already by dotnet/sdk#47291 |
@ViktorHofer, How do you feel about closing this? The motivation behind this was the belief that the reference packages were only needed because of the way SBRP was defined with package downloads. The size of the SBRPs in the archive are currently 33.8 MB so from that perspective additional work to remove these doesn't feel justified. There is potential value in providing the ability to build the VMR's msbuild tasks against live references from the previous SB artifacts but the motivation for that work is different. If you feel that should still be pursued, I think a separate issue should be opened that accurately captures the motivation. |
Agreed, let's close this one. We depend on two SBRP packages in the VMR orchestrator: I will file a new issue to track adding support for referencing previously SB artifacts in the VMR orchestrator: #4976 |
Reopening, as this will be unblocked with #5065 |
Once #1690 is fixed, there will no longer be a need to include the reference packages in the source build artifacts. Additionally the special logic to initialize the prereqs/packages/references as part of initializing source build can be removed.
The text was updated successfully, but these errors were encountered: