Skip to content

Remove reference packages from source build artifacts #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelSimons opened this issue Mar 4, 2025 · 5 comments
Open

Remove reference packages from source build artifacts #4930

MichaelSimons opened this issue Mar 4, 2025 · 5 comments
Labels
area-sbrp Source build reference packages

Comments

@MichaelSimons
Copy link
Member

Once #1690 is fixed, there will no longer be a need to include the reference packages in the source build artifacts. Additionally the special logic to initialize the prereqs/packages/references as part of initializing source build can be removed.

@MichaelSimons MichaelSimons added the area-sbrp Source build reference packages label Mar 4, 2025
@MichaelSimons MichaelSimons moved this from Backlog to 10.0 in .NET Source Build Mar 4, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 5, 2025

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Mar 6, 2025

[Triage] It turns out the reference packages are required during source build initialization. For example they are required to build the msbuild tasks. @ViktorHofer has an idea on how we could eliminate the dependency by using n-1 artifacts. Assigning to him as he was going to create a POC of this. If this doesn't prove out, we should just close this. The benefits are relatively low given how small the source build reference packages are these days (~25 MB).

this comment](#4930 (comment)) was address already by dotnet/sdk#47291

@MichaelSimons MichaelSimons moved this from 10.0 to In Progress in .NET Source Build Mar 6, 2025
@MichaelSimons
Copy link
Member Author

@ViktorHofer, How do you feel about closing this? The motivation behind this was the belief that the reference packages were only needed because of the way SBRP was defined with package downloads. The size of the SBRPs in the archive are currently 33.8 MB so from that perspective additional work to remove these doesn't feel justified.

There is potential value in providing the ability to build the VMR's msbuild tasks against live references from the previous SB artifacts but the motivation for that work is different. If you feel that should still be pursued, I think a separate issue should be opened that accurately captures the motivation.

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 26, 2025

Agreed, let's close this one. We depend on two SBRP packages in the VMR orchestrator: Microsoft.Build.NoTargets and Microsoft.Build.Traversal. Those are strong dependencies and we would need to special case them which is probably not worth it.

I will file a new issue to track adding support for referencing previously SB artifacts in the VMR orchestrator: #4976

@ViktorHofer ViktorHofer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Mar 26, 2025
@NikolaMilosavljevic
Copy link
Member

Reopening, as this will be unblocked with #5065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sbrp Source build reference packages
Projects
Archived in project
Development

No branches or pull requests

3 participants