Generate poison report (prebuilt leaks) on CentOS (#879)

Author: dagood

.vsts.pipelines/builds/ci.yml

@@ -10,6 +10,7 @@ jobs:
   parameters:
     job: centos71
     imageName: microsoft/dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416
+    reportPrebuiltLeaks: true
     matrix:
       Production: {}
       Online: { type: Online }

.vsts.pipelines/jobs/ci-linux.yml

@@ -5,6 +5,7 @@ parameters:
   pool:
     name: Hosted Ubuntu 1604
   imageName: null
+  reportPrebuiltLeaks: false
 
 jobs:
 - job: ${{ parameters.job }}
@@ -28,6 +29,7 @@ jobs:
     docker.tb.work: -w /tb
     dropDirectory: $(stagingDirectory)/drop
     imageName: ${{ parameters.imageName }}
+    reportPrebuiltLeaks: ${{ parameters.reportPrebuiltLeaks }}
     rootDirectory: $(Build.SourcesDirectory)/..
     stagingDirectory: $(rootDirectory)/sb/staging
     tarballName: tarball_$(Build.BuildId)
@@ -68,7 +70,7 @@ jobs:
     displayName: Build source-build
     timeoutInMinutes: 120
 
-  # Run smoke tests.
+  # Run smoke tests. This is needed even in tarball legs to create the smoke-test-prereqs archive.
   - script: |
       set -x
       df -h
@@ -82,9 +84,13 @@ jobs:
   - script: |
       set -x
       df -h
+      args="--skip-build"
+      if [ "$(reportPrebuiltLeaks)" = "true" ]; then
+        args="$args --enable-leak-detection"
+      fi
       $(docker.run) $(docker.tb.map) $(docker.src.map) $(docker.src.work) $(imageName) ./build-source-tarball.sh \
         "/tb/$(tarballName)" \
-        --skip-build
+        $args
     displayName: Create tarball
     condition: and(succeeded(), eq(variables['sb.tarball'], true))
 
@@ -114,10 +120,15 @@ jobs:
       if [ "$(sb.tarballOffline)" = "true" ]; then
         networkArg="--network=none"
       fi
+      poisonArg=
+      if [ "$(sb.tarball)" != "true" ]; then
+        poisonArg="/p:EnablePoison=true"
+      fi
       $(docker.run) $(docker.tb.map) $(docker.tb.work) $networkArg $(imageName) "$(tarballName)/build.sh" \
         /p:Configuration=$(sb.configuration) \
         /p:PortableBuild=$(sb.portable) \
-        /p:FailOnPrebuiltBaselineError=true
+        /p:FailOnPrebuiltBaselineError=true \
+        $poisonArg
     displayName: Build tarball
     timeoutInMinutes: 120
     condition: and(succeeded(), eq(variables['sb.tarball'], true))

.vsts.pipelines/jobs/ci-osx.yml

@@ -13,7 +13,7 @@ jobs:
   timeoutInMinutes: 240
   variables:
     # Prefix to distinguish artifacts from different legs.
-    artifactName: ${{ format('$(type) {0}', parameters.job) }}
+    artifactName: ${{ format('{0} $(type)', parameters.job) }}
     logsDirectory: $(Build.ArtifactStagingDirectory)/logs
     SOURCE_BUILD_SKIP_SUBMODULE_CHECK: true
     # Default type, can be overridden by matrix legs.