Reuse SDK directory for version parsing and smoke-tests

Modify smoke-test.sh to use the same extracted cli directory as the one
we use to parse the SDK/Runtime/ASP version.

The smoke-test.sh script offers to interactively delete
$SCRIPT_ROOT/smoke-testing if it exists. That interactive prompt breaks
CI. So we can't use the smoke-testing dir. Instead, point smoke-test.sh
to a different directory (outside of $SCRIPT_ROOT/smoke-testing) so it
can reuse that.

Author: omajid

build.proj

@@ -138,15 +138,16 @@
     <WriteLinesToFile File="$(CompletedSemaphorePath)ReportPoisonUsage.complete" Overwrite="true" />
   </Target>
 
-  <Target Name="WriteVersionsToFile"
+  <Target Name="VerifyAndWriteVersionsToFile"
           AfterTargets="Build">
 
     <ItemGroup>
       <FinalSdkTarball Include="$(OutputPath)\dotnet-sdk-$(MajorVersion)*$(TarBallExtension)" />
     </ItemGroup>
 
     <PropertyGroup>
-      <ExtractedPath>$(BaseOutputPath)\extracted-sdk\</ExtractedPath>
+      <!-- Shared path with smoke-test.sh -->
+      <ExtractedPath>$(BaseOutputPath)\builtCli\</ExtractedPath>
     </PropertyGroup>
 
     <MakeDir Directories="$(ExtractedPath)" />

smoke-test.sh

@@ -51,7 +51,8 @@ excludeLocalTests=false
 excludeOnlineTests=false
 devCertsVersion="$DEV_CERTS_VERSION_DEFAULT"
 testingDir="$SCRIPT_ROOT/testing-smoke"
-cliDir="$testingDir/builtCli"
+# Shared path with build.proj
+cliDir="$SCRIPT_ROOT/artifacts/builtCli"
 logFile="$testingDir/smoke-test.log"
 restoredPackagesDir="$testingDir/packages"
 testingHome="$testingDir/home"
@@ -611,11 +612,14 @@ echo "<Project />" | tee Directory.Build.props > Directory.Build.targets
 
 # Unzip dotnet if the dotnetDir is not specified
 if [ "$dotnetDir" == "" ]; then
-    OUTPUT_DIR="$SCRIPT_ROOT/artifacts/$buildArch/$configuration/"
-    DOTNET_TARBALL="$(ls "${OUTPUT_DIR}${TARBALL_PREFIX}${VERSION_PREFIX}"*)"
+    # It's possible that build.proj extracted the just-built dotnet tarball for other processing already
+    if [ ! -d "$cliDir" ]; then
+        OUTPUT_DIR="$SCRIPT_ROOT/artifacts/$buildArch/$configuration/"
+        DOTNET_TARBALL="$(ls "${OUTPUT_DIR}${TARBALL_PREFIX}${VERSION_PREFIX}"*)"
 
-    mkdir -p "$cliDir"
-    tar xzf "$DOTNET_TARBALL" -C "$cliDir"
+        mkdir -p "$cliDir"
+        tar xzf "$DOTNET_TARBALL" -C "$cliDir"
+    fi
     dotnetDir="$cliDir"
 else
     if ! [[ "$dotnetDir" = /* ]]; then