Skip to content

Commit 8a18c55

Browse files
authored
Make ./smoke-test.sh --targetRid $RID work (#2155)
The argument isn't read before we start using the value of targetRid, so defer using targetRid until after the argument has been read. Fixes: #2081
1 parent 8cbe02c commit 8a18c55

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

smoke-test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ DEV_CERTS_VERSION_DEFAULT=5.0.0-preview.3
1010
__ROOT_REPO=$(sed 's/\r$//' "$SCRIPT_ROOT/artifacts/obj/rootrepo.txt") # remove CR if mounted repo on Windows drive
1111
executingUserHome=${HOME:-}
1212

13-
echo "RID to test: ${targetRid?not specified. Use ./build.sh --run-smoke-test to detect RID, or specify manually.}"
14-
1513
export DOTNET_CLI_TELEMETRY_OPTOUT=1
1614
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
1715

@@ -586,6 +584,8 @@ function copyRestoredPackages() {
586584
fi
587585
}
588586

587+
echo "RID to test: ${targetRid?not specified. Use ./build.sh --run-smoke-test to detect RID, or specify manually.}"
588+
589589
if [ "$__ROOT_REPO" != "known-good" ]; then
590590
echo "Skipping smoke-tests since cli was not built";
591591
exit

0 commit comments

Comments
 (0)