Fix Windows build: clean submodules (#911)

Author: dagood

.vsts.pipelines/builds/matrix.yml

@@ -48,15 +48,17 @@ jobs:
     job: osx
     pool:
       name: Hosted macOS
-    buildScript: ./build.sh
+    scriptPrefix: ./
+    scriptSuffix: .sh
     setupMac: true
 
 - template: ../jobs/ci-local.yml
   parameters:
     job: windows
     pool:
       name: ${{ parameters.windowsPoolName }}
-    buildScript: build.cmd
+    scriptPrefix: ''
+    scriptSuffix: .cmd
     setupWindows: true
     skipSmokeTest: true
     failOnPrebuiltBaselineError: false

.vsts.pipelines/jobs/ci-local.yml

@@ -3,7 +3,8 @@ parameters:
   matrix:
     Production: {}
   pool: null
-  buildScript: null
+  scriptPrefix: null
+  scriptSuffix: null
   setupMac: false
   setupWindows: false
   skipSmokeTest: false
@@ -41,6 +42,11 @@ jobs:
   - script: git clean -xdff
     displayName: Clean leftover submodules
 
+  # Run 'clean -a' script to recursively clean submodules: AzDO doesn't do this, and otherwise we
+  # fail to apply patches on persistent machines like dotnet-external-temp.
+  - script: ${{ format('{0}clean{1} -a', parameters.scriptPrefix, parameters.scriptSuffix) }}
+    displayName: Run source-build 'clean all' script
+
   - template: ../steps/check-space-powershell.yml
 
   - ${{ if eq(parameters.setupMac, true) }}:
@@ -56,15 +62,15 @@ jobs:
   - template: ../steps/check-space-powershell.yml
 
   # Build source-build.
-  - script: ${{ format('{0} $(args.build)', parameters.buildScript) }}
+  - script: ${{ format('{0}build{1} $(args.build)', parameters.scriptPrefix, parameters.scriptSuffix) }}
     displayName: Build source-build
     timeoutInMinutes: 150
 
   - template: ../steps/check-space-powershell.yml
 
   # Run smoke tests.
   - ${{ if ne(parameters.skipSmokeTest, true) }}:
-    - bash: ${{ format('{0} $(args.smokeTest)', parameters.buildScript) }}
+    - bash: ${{ format('{0}build{1} $(args.smokeTest)', parameters.scriptPrefix, parameters.scriptSuffix) }}
       displayName: Run smoke-test
 
   # Gather artifacts. Uses git bash on Windows.