Less verbose tarball build, avoid CLI first-run init during clean.sh (#818)

* Copy dotnet env vars from build scripts to clean

Avoid doing first-time initialization during clean script execution.

* Less verbose tarball build, add logging to clarify

Reduce tarball build console verbosity to default. Previously, the verbosity was one way to determine whether you're in the middle of a tarball build or a tarball production build, so compensate by adding a note in the Build target messages.

While making changes nearby, fix the 'Enivornment Varibles' typo.

Author: dagood

clean.cmd

@@ -9,6 +9,9 @@ if [%1] == [-a] (
 )
 
 if EXIST "%~dp0Tools\dotnetcli\dotnet.exe" (
+  set DOTNET_CLI_TELEMETRY_OPTOUT=1
+  set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
+  set DOTNET_MULTILEVEL_LOOKUP=0
   "%~dp0Tools\dotnetcli\dotnet.exe" msbuild "%~dp0build.proj" -t:Clean
   exit /b %ERRORLEVEL%
 )

clean.sh

@@ -14,6 +14,9 @@ fi
 SCRIPT_ROOT="$(cd -P "$( dirname "$0" )" && pwd)"
 
 if [ -e "$SCRIPT_ROOT/Tools/dotnetcli/dotnet" ]; then
+    export DOTNET_CLI_TELEMETRY_OPTOUT=1
+    export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
+    export DOTNET_MULTILEVEL_LOOKUP=0
     "$SCRIPT_ROOT/Tools/dotnetcli/dotnet" msbuild "$SCRIPT_ROOT/build.proj" -t:Clean
     exit $?
 fi

repos/dir.props

@@ -35,6 +35,13 @@
     <OrchestratedManifestBuildName Condition="'$(OrchestratedManifestBuildName)' == ''">$(RepositoryName)</OrchestratedManifestBuildName>
   </PropertyGroup>
 
+  <!-- A human-readable description of what's building and why. -->
+  <PropertyGroup>
+    <ProjectBuildReason>'$(RepositoryName)'</ProjectBuildReason>
+    <ProjectBuildReason Condition="'$(OfflineBuild)' != 'true' AND '$(ArchiveDownloadedPackages)' == 'true'">$(ProjectBuildReason) to produce tarball</ProjectBuildReason>
+    <ProjectBuildReason Condition="'$(OfflineBuild)' == 'true'">$(ProjectBuildReason) in tarball</ProjectBuildReason>
+  </PropertyGroup>
+
   <!-- for RTM only, default to stabilized builds because that's what matches the official builds -->
   <!-- once https://github.com/dotnet/source-build/issues/550 is fixed we will be able to determine this automatically -->
   <PropertyGroup>

repos/dir.targets

@@ -229,15 +229,15 @@
   </Target>
 
   <Target Name="Build" DependsOnTargets="BuildRepoReferences">
-    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Building '$(RepositoryName)'" />
+    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Building $(ProjectBuildReason)" />
     <Message Importance="High" Text="Running command:" />
     <Message Importance="High" Text="  $(BuildCommand) $(RepoApiArgs)" Condition="'$(BuildCommand)' != ''" />
     <Message Importance="High" Text="  Using custom build target" Condition="'$(BuildCommand)' == ''" />
     <Message Importance="High" Text="  Log: $(RepoConsoleLogFile)" />
-    <Message Importance="High" Text="  With Enivornment Varibles:" />
+    <Message Importance="High" Text="  With Environment Variables:" />
     <Message Importance="High" Text="    %(EnvironmentVariables.Identity)" />
     <CallTarget Targets="RepoBuild" />
-    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Building '$(RepositoryName)'...done" />
+    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Building $(ProjectBuildReason)...done" />
     <OnError ExecuteTargets="ReportRepoError" />
   </Target>
 
@@ -255,14 +255,14 @@
   </Target>
 
   <Target Name="Package" AfterTargets="Build" Condition="'$(BuildPackagesCommand)' != ''">
-    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging '$(RepositoryName)'" />
+    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging $(ProjectBuildReason)" />
     <Message Importance="High" Text="Running command:" />
     <Message Importance="High" Text="  $(BuildPackagesCommand)" />
     <Message Importance="High" Text="  Log: $(RepoConsoleLogFile)" />
-    <Message Importance="High" Text="  With Enivornment Varibles:" />
+    <Message Importance="High" Text="  With Environment Variables:" />
     <Message Importance="High" Text="    %(EnvironmentVariables.Identity)" />
     <Exec Command="$(BuildPackagesCommand) $(RedirectRepoOutputToLog)" WorkingDirectory="$(ProjectDirectory)" EnvironmentVariables="@(EnvironmentVariables)" />
-    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging '$(RepositoryName)'...done" />
+    <Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging $(ProjectBuildReason)...done" />
     <OnError ExecuteTargets="ReportRepoError" />
   </Target>
 

support/tarball/build.sh

@@ -11,7 +11,7 @@ export DOTNET_CLI_TELEMETRY_OPTOUT=1
 export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
 export NUGET_PACKAGES="$SCRIPT_ROOT/packages/"
 
-MSBUILD_ARGUMENTS=("/p:OfflineBuild=true" "/flp:v=detailed" "/clp:v=detailed")
+MSBUILD_ARGUMENTS=("/p:OfflineBuild=true" "/flp:v=detailed")
 
 echo "Rebuild reference assemblies"
 $CLI_ROOT/dotnet $CLI_ROOT/sdk/$CLI_VERSION/MSBuild.dll $SCRIPT_ROOT/tools-local/init-build.proj /t:BuildReferenceAssemblies ${MSBUILD_ARGUMENTS[@]} "$@"