Skip to content

Commit 1ec94c6

Browse files
authored
Organize build args for readability/mergeability (#788)
1 parent 52c99a5 commit 1ec94c6

12 files changed

+156
-30
lines changed

repos/application-insights.proj

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,21 @@
1010
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1111

1212
<Target Name="RepoBuild">
13-
<Exec Command="$(DotnetToolCommand) restore $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) /bl:restore.binlog $(RedirectRepoOutputToLog)"
13+
<PropertyGroup>
14+
<BuildCommandArgs>$(ProjectDirectory)/Microsoft.ApplicationInsights.csproj</BuildCommandArgs>
15+
<BuildCommandArgs>$(BuildCommandArgs) /p:Configuration=$(Configuration)</BuildCommandArgs>
16+
<BuildCommandArgs>$(BuildCommandArgs) $(RedirectRepoOutputToLog)</BuildCommandArgs>
17+
</PropertyGroup>
18+
19+
<Exec Command="$(DotnetToolCommand) restore /bl:restore.binlog $(BuildCommandArgs) "
1420
EnvironmentVariables="@(EnvironmentVariables)"
1521
WorkingDirectory="$(ProjectDirectory)" />
1622

17-
<Exec Command="$(DotnetToolCommand) build $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) /bl:build.binlog $(RedirectRepoOutputToLog)"
23+
<Exec Command="$(DotnetToolCommand) build /bl:build.binlog $(BuildCommandArgs)"
1824
EnvironmentVariables="@(EnvironmentVariables)"
1925
WorkingDirectory="$(ProjectDirectory)" />
2026

21-
<Exec Command="$(DotnetToolCommand) pack $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) /bl:pack.binlog $(RedirectRepoOutputToLog)"
27+
<Exec Command="$(DotnetToolCommand) pack /bl:pack.binlog $(BuildCommandArgs)"
2228
EnvironmentVariables="@(EnvironmentVariables)"
2329
WorkingDirectory="$(ProjectDirectory)" />
2430
</Target>

repos/core-setup.proj

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,19 @@
88
<OverridePortableBuild Condition="'$(TargetOS)' == 'OSX'">true</OverridePortableBuild>
99
<OverrideTargetRid Condition="'$(TargetOS)' == 'OSX'">osx-x64</OverrideTargetRid>
1010

11-
<BuildArguments>-ConfigurationGroup=$(Configuration) -PortableBuild=$(OverridePortableBuild) -SkipTests=true </BuildArguments>
11+
<BuildArguments>-ConfigurationGroup=$(Configuration)</BuildArguments>
12+
<BuildArguments>$(BuildArguments) -PortableBuild=$(OverridePortableBuild)</BuildArguments>
13+
<BuildArguments>$(BuildArguments) -SkipTests=true</BuildArguments>
1214
<BuildArguments Condition="$(Platform.Contains('arm'))">$(BuildArguments) -TargetArchitecture=$(Platform) -DisableCrossgen=true -CrossBuild=true</BuildArguments>
13-
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments) -- /p:BuildDebPackage=false /p:BuildAllPackages=true /p:OutputRid=$(OverrideTargetRid) /bl</BuildCommand>
15+
<BuildArguments>$(BuildArguments) --</BuildArguments>
16+
<BuildArguments>$(BuildArguments) /p:BuildDebPackage=false</BuildArguments>
17+
<BuildArguments>$(BuildArguments) /p:BuildAllPackages=true</BuildArguments>
18+
<BuildArguments>$(BuildArguments) /p:OutputRid=$(OverrideTargetRid)</BuildArguments>
19+
<BuildArguments>$(BuildArguments) /bl</BuildArguments>
20+
21+
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments)</BuildCommand>
1422
<BuildCommand Condition="$(Platform.Contains('arm'))">$(ArmEnvironmentVariables) $(BuildCommand)</BuildCommand>
23+
1524
<OfficialBuildId>20180919-01</OfficialBuildId>
1625

1726
<!-- Need to set $(PackagesOutput) so WriteVersions writes the versions file for cli, until cli respects auto-dependency flow -->

repos/coreclr.proj

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,18 @@
66
<OverridePortableBuild>$(PortableBuild)</OverridePortableBuild>
77
<OverridePortableBuild Condition="'$(TargetOS)' == 'OSX'">true</OverridePortableBuild>
88

9-
<BuildArguments>$(Platform) $(Configuration) skiptests -PortableBuild=$(OverridePortableBuild) </BuildArguments>
9+
<BuildArguments>$(Platform) $(Configuration) skiptests</BuildArguments>
10+
<BuildArguments>$(BuildArguments) -PortableBuild=$(OverridePortableBuild)</BuildArguments>
1011
<BuildArguments Condition="'$(SkipDisablePgo)' != 'true'">$(BuildArguments) -nopgooptimize</BuildArguments>
1112
<BuildArguments Condition="'$(OS)' != 'Windows_NT'">$(BuildArguments) msbuildonunsupportedplatform</BuildArguments>
1213
<BuildArguments Condition="'$(UseSystemLibraries)' == 'true'">$(BuildArguments) cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=TRUE</BuildArguments>
1314
<BuildArguments Condition="$(Platform.Contains('arm'))">$(BuildArguments) skipnuget cross -skiprestore cmakeargs -DFEATURE_GDBJIT=TRUE</BuildArguments>
14-
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments) --</BuildCommand>
15+
<BuildArguments>$(BuildArguments) --</BuildArguments>
16+
17+
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments)</BuildCommand>
18+
1519
<BuildCommand Condition="$(Platform.Contains('arm'))">$(ArmEnvironmentVariables) $(BuildCommand)</BuildCommand>
20+
1621
<CleanCommand>$(ProjectDirectory)/clean$(ShellExtension)</CleanCommand>
1722
<OfficialBuildId>20180919-02</OfficialBuildId>
1823
</PropertyGroup>

repos/corefx.proj

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,18 @@
88
<OverrideTargetRid>$(TargetRid)</OverrideTargetRid>
99
<OverrideTargetRid Condition="'$(TargetOS)' == 'OSX'">osx-x64</OverrideTargetRid>
1010

11-
<BuildArguments>-$(Configuration) -buildArch=$(Platform) -portable=$(OverridePortableBuild) -BuildTests=false -PackageRid=$(OverrideTargetRid)</BuildArguments>
12-
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments) -- /p:BuildAllPackages=true /bl</BuildCommand>
11+
<BuildArguments>-$(Configuration)</BuildArguments>
12+
<BuildArguments>$(BuildArguments) -buildArch=$(Platform)</BuildArguments>
13+
<BuildArguments>$(BuildArguments) -portable=$(OverridePortableBuild) </BuildArguments>
14+
<BuildArguments>$(BuildArguments) -BuildTests=false</BuildArguments>
15+
<BuildArguments>$(BuildArguments) -PackageRid=$(OverrideTargetRid)</BuildArguments>
16+
<BuildArguments>$(BuildArguments) --</BuildArguments>
17+
<BuildArguments>$(BuildArguments) /p:BuildAllPackages=true</BuildArguments>
18+
<BuildArguments>$(BuildArguments) /bl</BuildArguments>
19+
20+
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments)</BuildCommand>
1321
<BuildCommand Condition="$(Platform.Contains('arm'))">$(ArmEnvironmentVariables) $(BuildCommand)</BuildCommand>
22+
1423
<PackagesOutput>$(ProjectDirectory)/bin/packages/$(Configuration)</PackagesOutput>
1524
<CleanCommand>$(ProjectDirectory)/clean$(ShellExtension)</CleanCommand>
1625
<OfficialBuildId>20180919-02</OfficialBuildId>

repos/msbuild.proj

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,22 @@
66
<!-- Override value from commit to match expected build. -->
77
<OfficialBuildId>20180426.1</OfficialBuildId>
88
<PackagesOutput>$(ProjectDirectory)/artifacts/$(Configuration)/packages</PackagesOutput>
9-
<OutputVersionArgs>/p:VersionPrefix=15.7.179 /p:DisableNerdbankVersioning=true /p:PreReleaseVersionLabel="" /p:BUILD_BUILDNUMBER=$(OfficialBuildId)</OutputVersionArgs>
10-
<BuildCommand>$(ProjectDirectory)build/build$(ShellExtension) build -DotNetBuildFromSource -DotNetCoreSdkDir $(DotNetCliToolDir) -bootstraponly -skiptests -pack -configuration $(Configuration) /p:GitHeadSha=$(GitCommitHash) $(OutputVersionArgs)</BuildCommand>
9+
10+
<OutputVersionArgs>/p:VersionPrefix=15.7.179</OutputVersionArgs>
11+
<OutputVersionArgs>$(OutputVersionArgs) /p:DisableNerdbankVersioning=true</OutputVersionArgs>
12+
<OutputVersionArgs>$(OutputVersionArgs) /p:PreReleaseVersionLabel=""</OutputVersionArgs>
13+
<OutputVersionArgs>$(OutputVersionArgs) /p:BUILD_BUILDNUMBER=$(OfficialBuildId)</OutputVersionArgs>
14+
15+
<BuildCommandArgs>build -DotNetBuildFromSource</BuildCommandArgs>
16+
<BuildCommandArgs>$(BuildCommandArgs) -DotNetCoreSdkDir $(DotNetCliToolDir)</BuildCommandArgs>
17+
<BuildCommandArgs>$(BuildCommandArgs) -bootstraponly</BuildCommandArgs>
18+
<BuildCommandArgs>$(BuildCommandArgs) -skiptests</BuildCommandArgs>
19+
<BuildCommandArgs>$(BuildCommandArgs) -pack</BuildCommandArgs>
20+
<BuildCommandArgs>$(BuildCommandArgs) -configuration $(Configuration)</BuildCommandArgs>
21+
<BuildCommandArgs>$(BuildCommandArgs) /p:GitHeadSha=$(GitCommitHash)</BuildCommandArgs>
22+
<BuildCommandArgs>$(BuildCommandArgs) $(OutputVersionArgs)</BuildCommandArgs>
23+
24+
<BuildCommand>$(ProjectDirectory)build/build$(ShellExtension) $(BuildCommandArgs)</BuildCommand>
1125
<SourceOverrideRepoApiImplemented>true</SourceOverrideRepoApiImplemented>
1226
<RepoApiImplemented>false</RepoApiImplemented>
1327
<UsesRepoToolset>true</UsesRepoToolset>

repos/nuget-client.proj

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,32 @@
2626

2727
<Target Name="RepoBuild"
2828
DependsOnTargets="InitSubmodules">
29+
<PropertyGroup>
30+
<BuildCommandBase>$(DotnetToolCommand) msbuild $(ProjectDirectory)/build/build.proj</BuildCommandBase>
31+
<BuildCommandBase>$(BuildCommandBase) /p:VisualStudioVerion=15.0</BuildCommandBase>
32+
<BuildCommandBase>$(BuildCommandBase) /p:Configuration=$(Configuration)</BuildCommandBase>
33+
<BuildCommandBase>$(BuildCommandBase) /p:BuildRTM=false</BuildCommandBase>
34+
<BuildCommandBase>$(BuildCommandBase) /p:BuildNumber=$(NuGetClientBuildNumber)</BuildCommandBase>
35+
</PropertyGroup>
2936

30-
<Exec Command="$(DotnetToolCommand) msbuild $(ProjectDirectory)/build/build.proj /t:RestoreXPLAT /p:VisualStudioVerion=15.0 /p:Configuration=$(Configuration) /p:BuildRTM=false /p:BuildNumber=$(NuGetClientBuildNumber) /bl:restore.binlog $(RedirectRepoOutputToLog)"
37+
<Exec Command="$(BuildCommandBase) /t:RestoreXPLAT /bl:restore.binlog $(RedirectRepoOutputToLog)"
3138
EnvironmentVariables="@(EnvironmentVariables)"
3239
WorkingDirectory="$(ProjectDirectory)" />
3340

34-
<Exec Command="$(DotnetToolCommand) msbuild $(ProjectDirectory)/build/build.proj /t:BuildXPLAT /p:VisualStudioVerion=15.0 /p:Configuration=$(Configuration) /p:BuildRTM=false /p:BuildNumber=$(NuGetClientBuildNumber) /bl:build.binlog $(RedirectRepoOutputToLog)"
41+
<Exec Command="$(BuildCommandBase) /t:BuildXPLAT /bl:build.binlog $(RedirectRepoOutputToLog)"
3542
EnvironmentVariables="@(EnvironmentVariables)"
3643
WorkingDirectory="$(ProjectDirectory)" />
3744

38-
<Exec Command="$(DotnetToolCommand) msbuild $(ProjectDirectory)/build/build.proj /t:PackXPLAT /p:VisualStudioVerion=15.0 /p:Configuration=$(Configuration) /p:BuildRTM=false /p:BuildNumber=$(NuGetClientBuildNumber) /p:PackageOutputPath=$(PackagesOutput) /p:NoPackageAnalysis=true /flp:v=detailed /bl:pack.binlog $(RedirectRepoOutputToLog)"
45+
<PropertyGroup>
46+
<PackCommand>$(BuildCommandBase) /t:PackXPlat</PackCommand>
47+
<PackCommand>$(PackCommand) /p:PackageOutputPath=$(PackagesOutput)</PackCommand>
48+
<PackCommand>$(PackCommand) /p:NoPackageAnalysis=true</PackCommand>
49+
<PackCommand>$(PackCommand) /flp:v=detailed</PackCommand>
50+
<PackCommand>$(PackCommand) /bl:pack.binlog</PackCommand>
51+
<PackCommand>$(PackCommand) $(RedirectRepoOutputToLog)</PackCommand>
52+
</PropertyGroup>
53+
54+
<Exec Command="$(PackCommand)"
3955
EnvironmentVariables="@(EnvironmentVariables)"
4056
WorkingDirectory="$(ProjectDirectory)" />
4157
</Target>

repos/roslyn.proj

Lines changed: 42 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,16 @@
55
<PropertyGroup>
66
<NuGetPackageVersion>2.3.2-beta1-61921-05</NuGetPackageVersion>
77
<BuildNumber>20180426.3</BuildNumber>
8-
<BuildCommand>$(DotnetToolCommand) build $(ProjectDirectory)/SourceBuild.sln /p:Configuration=$(Configuration) /p:OfficialBuild=true /p:BuildNumber=$(BuildNumber) /bl:build.binlog</BuildCommand>
8+
9+
<BuildCommandArgs>build</BuildCommandArgs>
10+
<BuildCommandArgs>$(BuildCommandArgs) $(ProjectDirectory)/SourceBuild.sln</BuildCommandArgs>
11+
<BuildCommandArgs>$(BuildCommandArgs) /p:Configuration=$(Configuration)</BuildCommandArgs>
12+
<BuildCommandArgs>$(BuildCommandArgs) /p:OfficialBuild=true</BuildCommandArgs>
13+
<BuildCommandArgs>$(BuildCommandArgs) /p:BuildNumber=$(BuildNumber)</BuildCommandArgs>
14+
<BuildCommandArgs>$(BuildCommandArgs) /bl:build.binlog</BuildCommandArgs>
15+
16+
<BuildCommand>$(DotnetToolCommand) $(BuildCommandArgs)</BuildCommand>
17+
918
<PackagesOutput>$(ProjectDirectory)/Binaries/packages</PackagesOutput>
1019
<RepoApiImplemented>false</RepoApiImplemented>
1120
<GlobalJsonFile>$(ProjectDirectory)global.json</GlobalJsonFile>
@@ -31,12 +40,19 @@
3140

3241
<Target Name="Restore" BeforeTargets="Build">
3342
<PropertyGroup>
34-
<RestoreArgs Condition="'$(OS)' != 'Windows_NT'">--disable-parallel</RestoreArgs>
43+
<RestoreArgs>restore</RestoreArgs>
44+
<RestoreArgs Condition="'$(OS)' != 'Windows_NT'">$(RestoreArgs) --disable-parallel</RestoreArgs>
45+
<RestoreArgs>$(RestoreArgs) $(ProjectDirectory)/SourceBuild.sln</RestoreArgs>
46+
<RestoreArgs>$(RestoreArgs) $(RedirectRepoOutputToLog)</RestoreArgs>
3547
</PropertyGroup>
3648

37-
<Exec Command="$(DotnetToolCommand) restore $(RestoreArgs) $(ProjectDirectory)/SourceBuild.sln $(RedirectRepoOutputToLog)"
49+
<Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Restoring 'roslyn'" />
50+
51+
<Exec Command="$(DotnetToolCommand) $(RestoreArgs)"
3852
WorkingDirectory="$(ProjectDirectory)"
3953
EnvironmentVariables="@(EnvironmentVariables)" />
54+
55+
<Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Restoring 'roslyn'...done" />
4056
</Target>
4157

4258
<Target Name="FixNuSpecFilePathSeparators" BeforeTargets="Build">
@@ -56,13 +72,34 @@
5672
</ItemGroup>
5773

5874
<Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging 'roslyn'" />
75+
5976
<!-- Publish MSBuild project so that Microsoft.NETCore.Compilers.nuspec can find runtimes. -->
60-
<Exec Command="$(DotnetToolCommand) msbuild %(PublishWithoutBuildingProject.Identity) /p:Configuration=$(Configuration) /p:TargetFramework=netcoreapp2.0 /t:PublishWithoutBuilding /bl:publish.binlog $(RedirectRepoOutputToLog)"
77+
<PropertyGroup>
78+
<PublishCommandArgs>msbuild</PublishCommandArgs>
79+
<PublishCommandArgs>$(PublishCommandArgs) /p:Configuration=$(Configuration)</PublishCommandArgs>
80+
<PublishCommandArgs>$(PublishCommandArgs) /p:TargetFramework=netcoreapp2.0</PublishCommandArgs>
81+
<PublishCommandArgs>$(PublishCommandArgs) /t:PublishWithoutBuilding</PublishCommandArgs>
82+
<PublishCommandArgs>$(PublishCommandArgs) /bl:publish.binlog</PublishCommandArgs>
83+
</PropertyGroup>
84+
85+
<Exec Command="$(DotnetToolCommand) $(PublishCommandArgs) %(PublishWithoutBuildingProject.Identity) $(RedirectRepoOutputToLog)"
6186
WorkingDirectory="$(ProjectDirectory)"
6287
EnvironmentVariables="@(EnvironmentVariables)" />
63-
<Exec Command="$(DotnetToolCommand) pack --no-build $(ProjectDirectory)/src/NuGet/NuGetProjectPackUtil.csproj -p:Configuration=$(Configuration) -p:NuspecFile=%(NuSpecFiles.Identity) -p:NuspecBasePath=$(ProjectDirectory)/Binaries/$(Configuration) -p:PackageOutputPath=$(PackagesOutput) -p:NuGetPackageKind=release /bl:pack.binlog $(RedirectRepoOutputToLog)"
88+
89+
<PropertyGroup>
90+
<PackCommandArgs>pack --no-build</PackCommandArgs>
91+
<PackCommandArgs>$(PackCommandArgs) $(ProjectDirectory)/src/NuGet/NuGetProjectPackUtil.csproj</PackCommandArgs>
92+
<PackCommandArgs>$(PackCommandArgs) -p:Configuration=$(Configuration)</PackCommandArgs>
93+
<PackCommandArgs>$(PackCommandArgs) -p:NuspecBasePath=$(ProjectDirectory)/Binaries/$(Configuration)</PackCommandArgs>
94+
<PackCommandArgs>$(PackCommandArgs) -p:PackageOutputPath=$(PackagesOutput)</PackCommandArgs>
95+
<PackCommandArgs>$(PackCommandArgs) -p:NuGetPackageKind=release</PackCommandArgs>
96+
<PackCommandArgs>$(PackCommandArgs) /bl:pack.binlog</PackCommandArgs>
97+
</PropertyGroup>
98+
99+
<Exec Command="$(DotnetToolCommand) $(PackCommandArgs) -p:NuspecFile=%(NuSpecFiles.Identity) $(RedirectRepoOutputToLog)"
64100
WorkingDirectory="$(ProjectDirectory)"
65101
EnvironmentVariables="@(EnvironmentVariables)" />
102+
66103
<Message Importance="High" Text="[$([System.DateTime]::Now.ToString('HH:mm:ss.ff'))] Packaging 'roslyn'...done" />
67104
</Target>
68105

repos/sdk.proj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,16 @@
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
55
<OfficialBuildId>20180919.1</OfficialBuildId>
6+
67
<OutputVersionArgs>/p:BUILD_BUILDNUMBER=$(OfficialBuildId)</OutputVersionArgs>
8+
79
<BuildCommandArgs>--pack --configuration $(Configuration) $(OutputVersionArgs)</BuildCommandArgs>
810

911
<!-- Pass in package version props using the Product Construction (ProdCon) API. -->
1012
<BuildCommandArgs>$(BuildCommandArgs) /p:PB_PackageVersionPropsUrl=file:%2F%2F$(PackageVersionPropsPath)</BuildCommandArgs>
1113

1214
<BuildCommand>$(ProjectDirectory)\build$(ShellExtension) $(BuildCommandArgs)</BuildCommand>
15+
1316
<OrchestratedManifestBuildName>dotnet/sdk</OrchestratedManifestBuildName>
1417
<!-- NuGet SDK resolver only checks nuget.config files. https://github.com/Microsoft/msbuild/issues/2914 -->
1518
<NuGetConfigFile>$(ProjectDirectory)/nuget.config</NuGetConfigFile>

repos/templating.proj

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,21 @@
2323
<ItemGroup>
2424
<RepositoryReference Include="clicommandlineparser" />
2525
</ItemGroup>
26+
2627
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
2728

2829
<Target Name="RepoBuild">
29-
<Exec Command="$(DotnetToolCommand) msbuild /t:Build @(MSBuildProperties->'/p:%(Identity)', ' ') $(ProjectDirectory)/build.proj /bl $(RedirectRepoOutputToLog)"
30-
EnvironmentVariables="@(EnvironmentVariables)"
31-
WorkingDirectory="$(ProjectDirectory)" />
30+
<PropertyGroup>
31+
<BuildCommandArgs>/t:Build</BuildCommandArgs>
32+
<BuildCommandArgs>$(BuildCommandArgs) /bl</BuildCommandArgs>
33+
<BuildCommandArgs>$(BuildCommandArgs) @(MSBuildProperties->'/p:%(Identity)', ' ')</BuildCommandArgs>
34+
<BuildCommandArgs>$(BuildCommandArgs) $(ProjectDirectory)build.proj</BuildCommandArgs>
35+
<BuildCommandArgs>$(BuildCommandArgs) $(RedirectRepoOutputToLog)</BuildCommandArgs>
36+
</PropertyGroup>
37+
38+
<Exec Command="$(DotnetToolCommand) msbuild $(BuildCommandArgs)"
39+
WorkingDirectory="$(ProjectDirectory)"
40+
EnvironmentVariables="@(EnvironmentVariables)" />
3241

3342
<!-- The templates are built to a different folder than the packages, copy them into the packages folder. -->
3443
<ItemGroup>

repos/vstest.proj

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,15 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) -DotnetBuildFromSource -DotnetCoreSdkDir $(DotNetCliToolDir) -c $(Configuration) -r $(TargetRid) -v 15.3.0 -vs preview-20170628-02</BuildCommand>
5+
<BuildCommandArgs>-DotNetBuildFromSource</BuildCommandArgs>
6+
<BuildCommandArgs>$(BuildCommandArgs) -DotNetCoreSdkDir $(DotNetCliToolDir)</BuildCommandArgs>
7+
<BuildCommandArgs>$(BuildCommandArgs) -c $(Configuration)</BuildCommandArgs>
8+
<BuildCommandArgs>$(BuildCommandArgs) -r $(TargetRid)</BuildCommandArgs>
9+
<BuildCommandArgs>$(BuildCommandArgs) -v 15.3.0</BuildCommandArgs>
10+
<BuildCommandArgs>$(BuildCommandArgs) -vs preview-20170628-02</BuildCommandArgs>
11+
12+
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildCommandArgs)</BuildCommand>
13+
614
<PackagesOutput>$(ProjectDirectory)/artifacts/$(Configuration)/packages</PackagesOutput>
715
<RepoApiImplemented>false</RepoApiImplemented>
816
<OrchestratedManifestBuildName>N/A</OrchestratedManifestBuildName>

0 commit comments

Comments
 (0)